Skip to content

Updates for maplibre maps - #4706

Merged
LiamConnors merged 45 commits into
masterfrom
maplibre-tests
Aug 29, 2024
Merged

Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom
maplibre-tests

Conversation

@LiamConnors

@LiamConnorsLiamConnors commented Aug 5, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Update docs
  • Add new px functions

@LiamConnorsLiamConnors changed the title Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors changed the title Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj reviewed Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md Outdated
@archmoj

archmoj commented Aug 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟
I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.
That way we could simply look at the main differences between the two.

Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.
This way we have docs for both mapbox and new maps on the other PR.
Thank you!

@archmoj

archmoj commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Here is a list of doc files that has mapbox in their name:

./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors

LiamConnors commented Aug 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Here is a list of doc files that has mapbox in their name:

./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed

@archmoj

archmoj commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.

@LiamConnors

LiamConnors commented Aug 6, 2024

Copy link
Copy Markdown
ContributorAuthor

Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.

This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161
But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.
What do you think @ndrezn@emilykl

@archmoj

archmoj commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson

@archmoj

archmoj commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.

@ndrezn

ndrezn commented Aug 6, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).

ndrezn
ndrezn reviewed Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj

archmoj commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.
We should possibly add hexbin_map. No?

@gvwilson

gvwilson commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.

LiamConnors
LiamConnors commented Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj reviewed Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj reviewed Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors commented Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md Outdated
emilykl
emilykl reviewed Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md Outdated
LiamConnors
LiamConnors commented Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md Outdated
archmoj
archmoj reviewed Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj reviewed Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md Outdated
archmoj
archmoj reviewed Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors commented Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md Outdated
archmoj
archmoj reviewed Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md Outdated
ndreznand others added 2 commits August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj approved these changes Aug 28, 2024
View reviewed changes

@archmojarchmoj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)

Other than that it looks great and works great too!

You may consider merging #4726 into this branch or target master after merging this PR.

LiamConnors
LiamConnors commented Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md Outdated
LiamConnorsand others added 4 commits August 29, 2024 09:31
@LiamConnorsLiamConnors changed the title Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors merged commit a747fea into masterAug 29, 2024
@LiamConnors
LiamConnors deleted the maplibre-tests branch August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl
2 more reviewers
@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Updates for maplibre maps by LiamConnors · Pull Request #4706 · plotly/plotly.py · GitHub
Skip to content
Updates for maplibre maps - #4706
Merged
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Aug 29, 2024
Merged
Updates for maplibre maps#4706
LiamConnors merged 45 commits into
masterfrom 
maplibre-tests
Conversation
@LiamConnors
@LiamConnorsLiamConnors
commented
Aug 5, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
  • Update docs
  • Add new px functions
@LiamConnorsLiamConnors
changed the title
Maplibre testsMaplibre updatesAug 5, 2024
@LiamConnorsLiamConnors
changed the title
Maplibre updatesDocs updates for new mapsAug 5, 2024
archmoj
archmoj
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
Outdated

@archmoj
archmoj
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
Great PR. Thanks @LiamConnors for all this. 🏅 🏆 🌟

I suggest we set status of this PR to on hold as we did for plotly/plotly.js#7015 and don't merge it.

That way we could simply look at the main differences between the two.
Then you could duplicate your branch, rename all the docs files that has mapbox in their name to map and then bring back the mapbox docs from master and open a new pull request.

This way we have docs for both mapbox and new maps on the other PR.

Thank you!
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Here is a list of doc files that has mapbox in their name:
./doc/python/mapbox-county-choropleth.md
./doc/python/mapbox-layers.md
./doc/python/filled-area-on-mapbox.md
./doc/python/mapbox-density-heatmaps.md
./doc/python/lines-on-mapbox.md
./doc/python/scattermapbox.md
./doc/python/hexbin-mapbox.md

I think leaving the file names as is is okay for now as they are not displayed in the docs and it makes it easier for anyone reviewing this PR to see what's changed
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
@LiamConnors
LiamConnors
commented
Aug 6, 2024

Copy link


Copy Markdown

ContributorAuthor
Yes we could keep mapbox names in this PR. But for the other one we want to merge those should be renamed as we need to keep doc for mapbox traces.
This PR keeps some mapbox examples. Like here https://github.com/plotly/plotly.py/pull/4706/files#diff-aeb7417e2580482c1fb42c4b976c4e0beb113fcb7333efee59c57bc06d3e04e6R138-R161

But I'm not sure we need to keep all examples written using Mapbox traces and the main focus of the pages should now be the new traces.

What do you think @ndrezn@emilykl
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
IMHO, for a while we need to keep mapbox examples until they could use the next plotly.py version in their systems.
@ndrezn@emilykl@gvwilson
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
Also having two versions (mapbox and new map) on two doc files, could help everyone see the difference between the two.
@ndrezn
ndrezn
commented
Aug 6, 2024•

edited

Loading

Copy link


Copy Markdown

Contributor
We should keep some mapbox examples, but like in plotly.py I would expect a deprecation notice associated with them. With the major version where we fully drop support for Mapbox I would also expect we drop these examples (and note in the new docs that these maps replace the previous Mapbox trace types with feature parity).
ndrezn
ndrezn
reviewed
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/choropleth-maps.md
@archmoj
archmoj
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
There is also hexbin_mapbox in figure_factory at packages/python/plotly/plotly/figure_factory/_hexbin_mapbox.py.

We should possibly add hexbin_map. No?
@gvwilson
gvwilson
commented
Aug 6, 2024

Copy link


Copy Markdown

Contributor
I'm OK with shipping most of the maps in this release and doing another with the small number of maps we didn't get to.
LiamConnors
LiamConnors
commented
Aug 6, 2024
View reviewed changes
Comment threaddoc/python/scattermapbox.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
archmoj
archmoj
reviewed
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
LiamConnors
LiamConnors
commented
Aug 27, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

emilykl
emilykl
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/migrate-to-maplibre.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/datashader.md
archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/lines-on-mapbox.md
LiamConnors
LiamConnors
commented
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/figure-structure.md
Outdated

archmoj
archmoj
reviewed
Aug 28, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

ndreznand others
added 2 commits
August 28, 2024 13:10
@ndrezn@emilykl
Update doc/python/migrate-to-maplibre.md
792a5e9
Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
@ndrezn@LiamConnors
Update doc/python/migrate-to-maplibre.md
af83303
Co-authored-by: Liam Connors <liam@plot.ly>
archmoj
archmoj
approved these changes
Aug 28, 2024
View reviewed changes
@archmojarchmoj
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one remaining comment here: #4706 (comment)
Other than that it looks great and works great too!
You may consider merging #4726 into this branch or target master after merging this PR.
LiamConnors
LiamConnors
commented
Aug 29, 2024
View reviewed changes
Comment threaddoc/python/axes.md
Outdated

LiamConnorsand others
added 4 commits
August 29, 2024 09:31
@LiamConnorsLiamConnors
changed the title
Docs updates for new mapsUpdates for maplibre mapsAug 29, 2024
@LiamConnors
LiamConnors
merged commit a747fea
into
masterAug 29, 2024
@LiamConnors
LiamConnors
deleted the

maplibre-tests

branch
August 29, 2024 17:00
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ndreznndreznAwaiting requested review from ndrezn
@emilyklemilyklAwaiting requested review from emilykl

2 more reviewers

@archmojarchmojarchmoj approved these changes
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

documentationwritten for humansfeaturesomething newP1needed for current cycle

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@LiamConnors@archmoj@ndrezn@gvwilson@emilykl