Skip to content

Add new map options to px and update plotly.js/master at 056799dfc705a4533935ae3169cc94d35bc44830 - #4726

Merged
LiamConnors merged 6 commits into
maplibre-testsfrom
maplibre-tests_with-px
Aug 29, 2024
Merged

Add new map options to px and update plotly.js/master at 056799dfc705a4533935ae3169cc94d35bc44830#4726
LiamConnors merged 6 commits into
maplibre-testsfrom
maplibre-tests_with-px

Conversation

@archmoj

@archmojarchmoj commented Aug 23, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

@archmoj

archmoj commented Aug 23, 2024

Copy link
Copy Markdown
ContributorAuthor

cc: birkskyum

archmoj
archmoj commented Aug 26, 2024
View reviewed changes
Comment threadpackages/python/plotly/plotly/express/_doc.py Outdated
LiamConnors
LiamConnors reviewed Aug 27, 2024
View reviewed changes
Comment threadpackages/python/plotly/plotly/express/_doc.py
@LiamConnors

LiamConnors commented Aug 27, 2024

Copy link
Copy Markdown
Contributor

This looks good to me. Was there a particular example you couldn't get to render @archmoj

ndrezn
ndrezn reviewed Aug 27, 2024
View reviewed changes

@ndreznndrezn left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a deprecation warning for Mapbox traces similar to plotly/plotly.js#7087, but in this case have it appear in the Python console in addition to in the browser console?

@archmoj@LiamConnors
Update packages/python/plotly/plotly/express/_doc.py
e243e6d
Co-authored-by: Liam Connors <liam@plot.ly>
@archmoj

archmoj commented Aug 27, 2024

Copy link
Copy Markdown
ContributorAuthor

Is it possible to add a deprecation warning for Mapbox traces similar to plotly/plotly.js#7087, but in this case have it appear in the Python console in addition to in the browser console?

If possible, that should be done in a separate PR.
This PR is already huge.

@ndreznndrezn mentioned this pull request Aug 28, 2024
Closed
@ndrezn

ndrezn commented Aug 28, 2024

Copy link
Copy Markdown
Contributor

@archmoj makes sense to me -- opened #4730 to cover that case.

@archmojarchmoj mentioned this pull request Aug 28, 2024
Merged
@archmoj

archmoj commented Aug 28, 2024

Copy link
Copy Markdown
ContributorAuthor

@LiamConnors Please take over this PR and once ready merge it into your doc PR or master?
I thought you may want to revert big commit of plotly.js update ba9c413 and just add the px parts to have viewable diffs. No?

@LiamConnors
LiamConnors merged commit 24730c3 into maplibre-testsAug 29, 2024
@ndrezn
ndrezn deleted the maplibre-tests_with-px branch August 29, 2024 15:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emilyklemilyklAwaiting requested review from emilykl
@ndreznndreznAwaiting requested review from ndrezn
2 more reviewers
@LiamConnorsLiamConnorsLiamConnors left review comments
@gvwilsongvwilsongvwilson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@LiamConnorsLiamConnors

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@archmoj@LiamConnors@ndrezn@gvwilson