Drop notebook 6 by marthacryan · Pull Request #4822 · plotly/plotly.py

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan · 2024-10-22T21:49:54Z

Note: this PR is on top of the changes from #4823 because the plotly.js version used in plotly.py is based on the jupyterlab extension code, and we needed a new place to store the plotly.js version. The widget seemed like a good place because all of the other javascript is removed in this PR.

Fixes#4779.

It appears that the entire packages/javascript/jupyterlab_plotly directory contains code that is either used to support very old versions of jupyter lab/notebook/voila, or is not used at all. This PR removes the entire directory in favor of having a very small packages/python/plotly/js directory that contains only the widget code (see #4663 for adding the widget code into that directory).

The last time that the jupyter extension was significantly changed was 3 years ago in #3142. @fcollonval described the files in the packages/javascript/jupyterlab_plotly directory in this comment. He did add support for federated extensions (new jupyter lab/notebook build), but I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly. @fcollonval if you know of any reason that that isn't true, please let me know!

To test:

Checkout branch
Create a new python env (conda, mamba, pipenv, etc)
git clean -f -x -d
cd packages/python/plotly
pip install -e .
pip install jupyter
Try it out in jupyter lab: jupyter lab
Try it out in jupyter notebook: jupyter notebook

…p-notebook-6

fcollonval · 2024-10-23T10:06:42Z

I wasn't able to find evidence that having an extension installed in jupyterlab >=3 or jupyter notebook >= 7 is even necessary for plotly

This is correct because the produced output is using html that will includes plotly.js the first time:

plotly.py/packages/python/plotly/plotly/io/_base_renderers.py

Line 368 in 7bcbb20

classNotebookRenderer(HtmlRenderer):

Dropping the mimerenderer factory will prevent plotly.json file to be opened in JupyterLab.

marthacryan · 2024-10-23T15:50:34Z

@fcollonval Thank you for the response! Also hi!

…ebook-6

archmoj · 2024-10-24T16:46:28Z

This is looking good to me.
@marthacryan Would you please add a changelog entry?

LiamConnors · 2024-10-24T20:26:29Z

@marthacryan, testing the FigureWidget in Notebook 7 and I get a JavaScript error:

Code is

import plotly.graph_objects as go
f = go.FigureWidget()
f

I have anywidget=0.9.13

marthacryan · 2024-10-24T20:57:15Z

@LiamConnors Looks like this wasn't happening for me because I hadn't added the npm install && npm run build step into pip install -e ., so the necessary javascript wasn't generated! I'll look into adding that

LiamConnors · 2024-10-24T21:15:44Z

In VS Code, I see this:

Not really sure what to make of it. I'm using the same environment as in a notebook launched in the browser.

I've commented here as I'm testing off this branch, but I guess this may be more related to #4823

LiamConnors · 2024-10-25T14:09:09Z

+### Jupyter Widget Support

-For use in the Jupyter Notebook, install the `notebook` and `ipywidgets`
+For use as a Jupyter widget, install `jupyter` and `anywidget`


The section above this talks about "JupyterLab Support" and should now mention anywidget. Wondering if this section should stay as "Jupyter Notebook Support"

I think maybe they should be combined. The usage is almost identical for jupyter Notebook and JupyterLab

…ebook-6

marthacryan · 2024-11-07T19:57:45Z

+ elif "jupyter-lab" in parent_process and jupyter_lab.__version__ < "3":
+ # Add warning about upgrading jupyterlab
+ warnings.warn(
+ f"Plotly version >= 6 requires JupyterLab >= 3 but you have {jupyter_lab.__version__} installed. To upgrade JupyterLab, please run `pip install jupyterlab --upgrade`."


Maybe put this in FigureWidget instead?

https://build.opensuse.org/request/show/1287194 by user bnavigator + anag_factory - Drop upstream patch plotly-pr4622-np2.patch - Remove jupyter sub-package, not part of the package anymore after the switch to anywidget gh#plotly/plotly.py#4823 - Remove notebook from jupyter package, as part of jupyter notebook 6 drop, gh#plotly/plotly.py#4822 - Update to 6.1.2 (CVE-2025-5889, bsc#1244347) * Fix type checking and code highlighting for graph_objects classes [#5199] - Release 6.1.1 * Prevent swallowing of ValueError when creating a figure with subplots [#3888] * Fix issue causing fig.write_image() to not generate an image [#5193] - Release 6.1.0 ## Updated * Add support for Kaleido>=v1.0.0 for image generation [#5062, #5177] * Reduce package bundle size by 18-24% via changes to code generation [#4978] ## Fixed * Fix third-party widget displa

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

marthacryan added 9 commits October 11, 2024 15:13

Add warning message when notebook version < 7 is used
e7b6d7a

Move files under python/plotly
590a4db

remove old javascript and fix install
cd7d587

Remove nbextension
4f2ce95

remove all jupyter extension code
0f16f0c

Merge branch 'anywidget' of github.com:marthacryan/plotly.py into dro…
5eff0ca
…p-notebook-6

Merge with anywidget branch
612ceec

Remove npm from release instructions
cb488ff

Remove more references to jupyterlab-plotly
4096595

marthacryan force-pushed the drop-notebook-6 branch from b05cac4 to 4096595Compare October 22, 2024 22:20

Merge with anywidget
f8fe306

marthacryan added 7 commits October 23, 2024 11:00

Fix filepath to js bundle in setup.py
3f6c8f7

Install before running npm build in ci
5b97f05

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3b94298
…ebook-6

Remove npm pack of jupyterlab extension
513798b

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
39e65af
…ebook-6

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
25cbf52
…ebook-6

Update path of bundle in setup.py
8e3354d

marthacryan marked this pull request as ready for review October 23, 2024 21:59

gvwilson assigned marthacryan Oct 24, 2024

gvwilson added feature something new P1 needed for current cycle labels Oct 24, 2024

LiamConnors reviewed Oct 25, 2024
View reviewed changes

update contributing to include new build instructions
60cc98f

marthacryan added 3 commits October 28, 2024 12:07

Merge branch 'anywidget' of github.com:plotly/plotly.py into drop-not…
3d2a234
…ebook-6

Merge with anywidget
4759697

Remove more references to old jupyter support from README
f6f2691

marthacryan merged commit ee67f2e into anywidgetNov 4, 2024

marthacryan deleted the drop-notebook-6 branch November 4, 2024 16:03

marthacryan commented Nov 7, 2024
View reviewed changes

marthacryan mentioned this pull request Dec 6, 2024
extension "jupyterlab-plotly" does not yet support the current version of JupyterLab (v4) #4354
Closed

marthacryan mentioned this pull request Mar 20, 2025
Add back the mime renderer JL extension #5096
Merged

danieleongari mentioned this pull request Apr 2, 2025
Plots not shown in HTML export for "vscode+notebook" renderer #4953
Closed

Uh oh!

Uh oh!

Conversation

marthacryan commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcollonval commented Oct 23, 2024

Uh oh!

marthacryan commented Oct 23, 2024

Uh oh!

archmoj commented Oct 24, 2024

Uh oh!

LiamConnors commented Oct 24, 2024

Uh oh!

marthacryan commented Oct 24, 2024

Uh oh!

LiamConnors commented Oct 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

marthacryan commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcollonval commented Oct 23, 2024

Uh oh!

marthacryan commented Oct 23, 2024

Uh oh!

archmoj commented Oct 24, 2024

Uh oh!

LiamConnors commented Oct 24, 2024

Uh oh!

marthacryan commented Oct 24, 2024

Uh oh!

LiamConnors commented Oct 24, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

marthacryan commented Oct 22, 2024• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fcollonval commented Oct 23, 2024

Uh oh!

marthacryan commented Oct 23, 2024

Uh oh!

archmoj commented Oct 24, 2024

Uh oh!

LiamConnors commented Oct 24, 2024

Uh oh!

marthacryan commented Oct 22, 2024•
edited
Loading

LiamConnors commented Oct 24, 2024•
edited
Loading

marthacryan commented Oct 22, 2024•
edited
Loading

LiamConnors commented Oct 24, 2024•
edited
Loading

marthacryan commented Oct 22, 2024•
edited
Loading

LiamConnors commented Oct 24, 2024•
edited
Loading

marthacryan commented Oct 22, 2024•
edited
Loading

LiamConnors commented Oct 24, 2024•
edited
Loading