Uh oh!
There was an error while loading. Please reload this page.
Drop support for Kaleido v0.x, and Orca - #5677
Conversation
0cfbbf4 to
6684995Compare
camdecoster
left a comment
There was a problem hiding this comment.
This looks good overall, but I have a few suggestions. Could you take a look at _sg_scraper.py? I think that might need to be updated since the Orca option with Sphinx Gallery was removed.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| fig: | ||
| Figure object or dict representing a figure | ||
There was a problem hiding this comment.
| fig: | |
| Figureobjectordictrepresentingafigure |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Link to issue
Closes#5623, closes#5371
Description of change
engineargument from image IO functionsNote:
plotly.js dev buildCI job is expected to fail, and docs build will fail until docs are updated by #5678.Testing strategy
test_kaleido_v0_error.pywhich verifies that the expected error is raised when image IO functions are called with Kaleido v0.x installedTo test locally:
fig.write_image(px.scatter(y=[1,2,3]), "fig.png")works as expected and produces an imagepip install "kaleido<1"fig.write_image(px.scatter(y=[1,2,3]), "fig.png")raises aRuntimeErrorsaying that only Kaleido version 1 and greater is supportedGuidelines