Skip to content

[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149

Merged
Xarlos89 merged 11 commits into
masterfrom
feature/execution-update
Aug 23, 2026
Merged

[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom
feature/execution-update

Conversation

@Jiggly-Balls

@Jiggly-BallsJiggly-Balls commented Jun 9, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Description of your PR

This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.

Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.

Describe your changes

Added

  • Added src.bot.cogs.BaseCog file which comes with some logging.

Fixed

  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport

Changed

  • Updated extension loading in src/bot/main.py

Issue link

Closes#147
Closes#148

Checklist

  • Does an issue of this PR exist and have you linked it?
  • Have your ran pre-commit over your PR?
  • Was this PR branched off from master?
  • Is this PR merging to master?

@Jiggly-BallsJiggly-Balls self-assigned this Jun 9, 2026
@Jiggly-BallsJiggly-Balls added chore repo/project maintenance type checking Fixes to type annotation errors labels Jun 9, 2026
Xarlos89
Xarlos89 previously requested changes Jul 4, 2026
View reviewed changes

@Xarlos89Xarlos89 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile

Comment threadsrc/api/api.py
@Xarlos89
Xarlos89 dismissed their stale reviewAugust 16, 2026 14:22

out of date

Xarlos89
Xarlos89 previously approved these changes Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89 merged commit 4c8a843 into masterAug 23, 2026
2 checks passed
@Xarlos89
Xarlos89 deleted the feature/execution-update branch August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error [BUG] Fix sync cog_unload method of MonthlyYappathon Cog

2 participants

@Jiggly-Balls@Xarlos89
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon by Jiggly-Balls · Pull Request #149 · practical-python-org/Eos · GitHub
Skip to content
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Merged
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Aug 23, 2026
Merged
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Conversation
@Jiggly-Balls
@Jiggly-BallsJiggly-Balls
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description of your PR
This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.
Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.
Describe your changes
Added
  • Added src.bot.cogs.BaseCog file which comes with some logging.
Fixed
  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport
Changed
  • Updated extension loading in src/bot/main.py
Issue link
Closes#147
Closes#148
Checklist
  •  Does an issue of this PR exist and have you linked it?
  •  Have your ran pre-commit over your PR?
  •  Was this PR branched off from master?
  •  Is this PR merging to master?
@Jiggly-BallsJiggly-Balls
self-assigned this
Jun 9, 2026
@Jiggly-BallsJiggly-Balls
added

chore
repo/project maintenance
type checking
Fixes to type annotation errors
labels
Jun 9, 2026
Xarlos89
Xarlos89
previously requested changes
Jul 4, 2026
View reviewed changes
@Xarlos89Xarlos89
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile
Comment threadsrc/api/api.py
@Xarlos89
Xarlos89
dismissed
their stale reviewAugust 16, 2026 14:22
out of date
Xarlos89
Xarlos89
previously approved these changes
Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89
merged commit 4c8a843
into
masterAug 23, 2026

2 checks passed

@Xarlos89
Xarlos89
deleted the

feature/execution-update

branch
August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error

[BUG] Fix sync cog_unload method of MonthlyYappathon Cog


2 participants

@Jiggly-Balls@Xarlos89

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon by Jiggly-Balls · Pull Request #149 · practical-python-org/Eos · GitHub
Skip to content
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Merged
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Aug 23, 2026
Merged
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Conversation
@Jiggly-Balls
@Jiggly-BallsJiggly-Balls
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description of your PR
This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.
Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.
Describe your changes
Added
  • Added src.bot.cogs.BaseCog file which comes with some logging.
Fixed
  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport
Changed
  • Updated extension loading in src/bot/main.py
Issue link
Closes#147
Closes#148
Checklist
  •  Does an issue of this PR exist and have you linked it?
  •  Have your ran pre-commit over your PR?
  •  Was this PR branched off from master?
  •  Is this PR merging to master?
@Jiggly-BallsJiggly-Balls
self-assigned this
Jun 9, 2026
@Jiggly-BallsJiggly-Balls
added

chore
repo/project maintenance
type checking
Fixes to type annotation errors
labels
Jun 9, 2026
Xarlos89
Xarlos89
previously requested changes
Jul 4, 2026
View reviewed changes
@Xarlos89Xarlos89
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile
Comment threadsrc/api/api.py
@Xarlos89
Xarlos89
dismissed
their stale reviewAugust 16, 2026 14:22
out of date
Xarlos89
Xarlos89
previously approved these changes
Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89
merged commit 4c8a843
into
masterAug 23, 2026

2 checks passed

@Xarlos89
Xarlos89
deleted the

feature/execution-update

branch
August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error

[BUG] Fix sync cog_unload method of MonthlyYappathon Cog


2 participants

@Jiggly-Balls@Xarlos89

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon by Jiggly-Balls · Pull Request #149 · practical-python-org/Eos · GitHub
Skip to content
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Merged
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Aug 23, 2026
Merged
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Conversation
@Jiggly-Balls
@Jiggly-BallsJiggly-Balls
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description of your PR
This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.
Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.
Describe your changes
Added
  • Added src.bot.cogs.BaseCog file which comes with some logging.
Fixed
  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport
Changed
  • Updated extension loading in src/bot/main.py
Issue link
Closes#147
Closes#148
Checklist
  •  Does an issue of this PR exist and have you linked it?
  •  Have your ran pre-commit over your PR?
  •  Was this PR branched off from master?
  •  Is this PR merging to master?
@Jiggly-BallsJiggly-Balls
self-assigned this
Jun 9, 2026
@Jiggly-BallsJiggly-Balls
added

chore
repo/project maintenance
type checking
Fixes to type annotation errors
labels
Jun 9, 2026
Xarlos89
Xarlos89
previously requested changes
Jul 4, 2026
View reviewed changes
@Xarlos89Xarlos89
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile
Comment threadsrc/api/api.py
@Xarlos89
Xarlos89
dismissed
their stale reviewAugust 16, 2026 14:22
out of date
Xarlos89
Xarlos89
previously approved these changes
Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89
merged commit 4c8a843
into
masterAug 23, 2026

2 checks passed

@Xarlos89
Xarlos89
deleted the

feature/execution-update

branch
August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error

[BUG] Fix sync cog_unload method of MonthlyYappathon Cog


2 participants

@Jiggly-Balls@Xarlos89

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon by Jiggly-Balls · Pull Request #149 · practical-python-org/Eos · GitHub
Skip to content
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Merged
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Aug 23, 2026
Merged
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Conversation
@Jiggly-Balls
@Jiggly-BallsJiggly-Balls
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description of your PR
This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.
Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.
Describe your changes
Added
  • Added src.bot.cogs.BaseCog file which comes with some logging.
Fixed
  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport
Changed
  • Updated extension loading in src/bot/main.py
Issue link
Closes#147
Closes#148
Checklist
  •  Does an issue of this PR exist and have you linked it?
  •  Have your ran pre-commit over your PR?
  •  Was this PR branched off from master?
  •  Is this PR merging to master?
@Jiggly-BallsJiggly-Balls
self-assigned this
Jun 9, 2026
@Jiggly-BallsJiggly-Balls
added

chore
repo/project maintenance
type checking
Fixes to type annotation errors
labels
Jun 9, 2026
Xarlos89
Xarlos89
previously requested changes
Jul 4, 2026
View reviewed changes
@Xarlos89Xarlos89
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile
Comment threadsrc/api/api.py
@Xarlos89
Xarlos89
dismissed
their stale reviewAugust 16, 2026 14:22
out of date
Xarlos89
Xarlos89
previously approved these changes
Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89
merged commit 4c8a843
into
masterAug 23, 2026

2 checks passed

@Xarlos89
Xarlos89
deleted the

feature/execution-update

branch
August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error

[BUG] Fix sync cog_unload method of MonthlyYappathon Cog


2 participants

@Jiggly-Balls@Xarlos89

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon by Jiggly-Balls · Pull Request #149 · practical-python-org/Eos · GitHub
Skip to content
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Merged
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Aug 23, 2026
Merged
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Conversation
@Jiggly-Balls
@Jiggly-BallsJiggly-Balls
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description of your PR
This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.
Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.
Describe your changes
Added
  • Added src.bot.cogs.BaseCog file which comes with some logging.
Fixed
  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport
Changed
  • Updated extension loading in src/bot/main.py
Issue link
Closes#147
Closes#148
Checklist
  •  Does an issue of this PR exist and have you linked it?
  •  Have your ran pre-commit over your PR?
  •  Was this PR branched off from master?
  •  Is this PR merging to master?
@Jiggly-BallsJiggly-Balls
self-assigned this
Jun 9, 2026
@Jiggly-BallsJiggly-Balls
added

chore
repo/project maintenance
type checking
Fixes to type annotation errors
labels
Jun 9, 2026
Xarlos89
Xarlos89
previously requested changes
Jul 4, 2026
View reviewed changes
@Xarlos89Xarlos89
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile
Comment threadsrc/api/api.py
@Xarlos89
Xarlos89
dismissed
their stale reviewAugust 16, 2026 14:22
out of date
Xarlos89
Xarlos89
previously approved these changes
Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89
merged commit 4c8a843
into
masterAug 23, 2026

2 checks passed

@Xarlos89
Xarlos89
deleted the

feature/execution-update

branch
August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error

[BUG] Fix sync cog_unload method of MonthlyYappathon Cog


2 participants

@Jiggly-Balls@Xarlos89

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon by Jiggly-Balls · Pull Request #149 · practical-python-org/Eos · GitHub
Skip to content
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon - #149
Merged
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Aug 23, 2026
Merged
[BUG FIX]: Implicit import errors & cog_load method of MonthlyYappathon#149
Xarlos89 merged 11 commits into
masterfrom 
feature/execution-update
Conversation
@Jiggly-Balls
@Jiggly-BallsJiggly-Balls
commented
Jun 9, 2026•

edited

Loading

Copy link


Copy Markdown

Member
Description of your PR
This PR fixes the cog_load method in src.bot.cogs.features.MonthlyYapathon from a sync method to an async method. Also fixes the implicit import type error by making all project level imports from relative & implicit relative to absolute imports.
Due to this I had to also update the extension loading slightly and the final run command of the bot in Dockerfile-bot. Additionally I also added a BaseCog class which comes with some logging when the cogs gets loaded / unloaded.
Describe your changes
Added
  • Added src.bot.cogs.BaseCog file which comes with some logging.
Fixed
  • Fixed cog_load method of MonthlyYappathon from sync to async.
  • Fixed type errors of reportImplicitRelativeImport
Changed
  • Updated extension loading in src/bot/main.py
Issue link
Closes#147
Closes#148
Checklist
  •  Does an issue of this PR exist and have you linked it?
  •  Have your ran pre-commit over your PR?
  •  Was this PR branched off from master?
  •  Is this PR merging to master?
@Jiggly-BallsJiggly-Balls
self-assigned this
Jun 9, 2026
@Jiggly-BallsJiggly-Balls
added

chore
repo/project maintenance
type checking
Fixes to type annotation errors
labels
Jun 9, 2026
Xarlos89
Xarlos89
previously requested changes
Jul 4, 2026
View reviewed changes
@Xarlos89Xarlos89
left a comment


Copy link


Copy Markdown

Collaborator
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think you missed the API dockerfile
Comment threadsrc/api/api.py
@Xarlos89
Xarlos89
dismissed
their stale reviewAugust 16, 2026 14:22
out of date
Xarlos89
Xarlos89
previously approved these changes
Aug 23, 2026
View reviewed changes
@Xarlos89
Xarlos89
merged commit 4c8a843
into
masterAug 23, 2026

2 checks passed

@Xarlos89
Xarlos89
deleted the

feature/execution-update

branch
August 23, 2026 14:40
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@Xarlos89Xarlos89Xarlos89 approved these changes

Assignees

@Jiggly-BallsJiggly-Balls

Labels

chorerepo/project maintenancetype checkingFixes to type annotation errors

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

[BUG] Fix implicit import type checking error

[BUG] Fix sync cog_unload method of MonthlyYappathon Cog


2 participants

@Jiggly-Balls@Xarlos89