Uh oh!
There was an error while loading. Please reload this page.
[Do not merge] [DRAFT] App bundle: AppFrame + AppHeader + AppFooter - #2089
[Do not merge] [DRAFT] App bundle: AppFrame + AppHeader + AppFooter#2089vdepizzol wants to merge 20 commits into
Conversation
|
| } | ||
| &:after { | ||
| @include minTouchTarget(var(--primer-control-medium-size), var(--primer-control-medium-size)); |
There was a problem hiding this comment.
Do you think the auto token for this type of behavior needs to be updated? 🤔 looks like we want 32px for fine. When would we want 16px?
--primer-control-minTarget-fine: var(--base-size-16);
vdepizzol
commented
Jul 1, 2022
Superseded by #2147. AppHeader and AppFooter will have their own PRs. |
✨ DRAFT ✨
The App bundle provides top-level structure to all pages, with the introduction of AppFrame, AppHeader, and AppFooter components.
AppFrame
AppFrame is a thin wrapper that holds the page together, while making sure that the page's global footer is always visible "after the fold". This guarantees that loading states won't show the footer temporarily, and allows the footer to include richer interactions without obfuscating or competing with the page contents.
Features
AppHeader
AppHeader provides a responsive global header, with logo and avatar triggers, scalable breadcrumb-style context region, search and system action buttons, local navigation support.
Features
Pending tasks
AppFooter
Coming soon
Pending tasks
Can these changes ship as is?