Skip to content

Upgrade to @primer/primtives@8.2.0 and @primer/stylelint-config@13.0.0-rc - #2634

Merged
jonrohan merged 12 commits into
mainfrom
upgrade_primitives_change_theme_imports
Jun 3, 2024
Merged

Upgrade to @primer/primtives@8.2.0 and @primer/stylelint-config@13.0.0-rc #2634
jonrohan merged 12 commits into
mainfrom
upgrade_primitives_change_theme_imports

Conversation

@jonrohan

@jonrohanjonrohan commented Jun 3, 2024•
edited
Loading

Copy link
Copy Markdown
Member

What are you trying to accomplish?

This is an intermediate step to #2607

This unblocks us by upgrading @primer/primitives and @primer/stylelint-config to the latest versions. And makes any migrations that are necessary for those upgrades.

Can these changes ship as is?

  • Yes, this PR does not depend on additional changes. 🚢

@changeset-bot

changeset-botBot commented Jun 3, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d0b1720

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/cssPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 15:41 Inactive
@jonrohanjonrohan changed the title Upgrade primitives change theme importsUpgrade to @primer/primtives@8.2.0 and @primer/stylelint-config@13.0.0-rc Jun 3, 2024
@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 16:17 Inactive
@jonrohan
jonrohan marked this pull request as ready for review June 3, 2024 16:21
@jonrohan
jonrohan requested review from a team as code ownersJune 3, 2024 16:21
@jonrohan
jonrohan requested a review from langermankJune 3, 2024 16:21
@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 16:22 Inactive
@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 16:24 Inactive
langermank
langermank reviewed Jun 3, 2024
View reviewed changes
Comment threadsrc/layout/page-layout.scss Outdated
langermank
langermank reviewed Jun 3, 2024
View reviewed changes
Comment threadsrc/layout/page-layout.scss Outdated
langermank
langermank reviewed Jun 3, 2024
View reviewed changes
Comment threadsrc/primitives/index.scss Outdated
langermank
langermank reviewed Jun 3, 2024
View reviewed changes
Comment threadsrc/support/variables/layout.scss Outdated
@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 16:45 Inactive
@jonrohan
jonrohan requested a review from langermankJune 3, 2024 16:52
@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 19:51 Inactive
@github-actions
github-actionsBottemporarily deployed to Storybook Preview June 3, 2024 19:56 Inactive
@jonrohan
jonrohan merged commit af3ab76 into mainJun 3, 2024
@jonrohan
jonrohan deleted the upgrade_primitives_change_theme_imports branch June 3, 2024 19:57
@primerprimerBot mentioned this pull request Jun 3, 2024
Merged
@camertroncamertron mentioned this pull request Jun 20, 2024
Merged
1 task
@jonrohanjonrohan mentioned this pull request Jul 8, 2024
Merged
1 task
This was referenced Jul 12, 2024
Merged
Closed
This was referenced Jul 23, 2024
Closed
Closed
Closed
@snyk-iosnyk-ioBot mentioned this pull request Aug 13, 2024
Open
@sennhann29sennhann29 mentioned this pull request Sep 6, 2024
Open
This was referenced Sep 13, 2024
Open
Open
Open
@KaliforniaShellKaliforniaShell mentioned this pull request Oct 2, 2024
Merged
@InfiniteLove2020InfiniteLove2020 mentioned this pull request Oct 3, 2024
Open
@Jekyle9444Jekyle9444 mentioned this pull request Nov 13, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@langermank