`children` types incompatible with React 18

[mattcosta7]

Describe the bug

When updating an application using primer to react and @types/react to v18, multiple primer components fail type checks on children, since React.FC no longer passes implicit children props (mirroring more closely the behavior of React.VFC from v17.

Related issue reported in #2103

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

Primer types work correctly with react 18

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[siddharthkp]

Oh that's a shame, would need a sweeping change but at least it's straightforward: https://stackoverflow.com/questions/71788254/react-18-typescript-children-fc

[mattcosta7]

There's a codemod for this https://github.com/eps1lon/types-react-codemod

[mattcosta7]

There's a codemod for this https://github.com/eps1lon/types-react-codemod

Re codemod - it works pretty well (used in another project), but if you already have something defined like

React.FC<React.PropsWithChildren<{}>>

it'll codemode to

React.FC<React.PropsWithChildren<React.PropsWithChildren<{}>>>

which is a bit annoying, but it does most of the heavy lifting