Skip to content

Update Tooltip v2 to use CSS Modules 💖 #3767

Description

@broccolinisoup

I'm creating this issue for tracking purposes. We plan to update the Tooltip v2 (draft) to use CSS modules and here are CSS variable suggestions @langermank left on the #3394

  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L16
- padding: 0.5em 0.75em;+ padding: var(--base-size-8) var(--base-size-4);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L44
- font: normal normal 11px/1.5 ${get('fonts.normal')};+ font: var(--text-body-shorthand-small);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L46
- color: ${get('colors.fg.onEmphasis')};+ color: var(--fgColor-onEmphasis);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L50
- background: ${get('colors.neutral.emphasisPlus')};+ background: var(--bgColor-emphasis);
  1. https://github.com/primer/react/blob/main/src/drafts/Tooltip/Tooltip.tsx#L51
- border-radius: ${get('radii.2')};+ border-radius: var(--borderRadius-medium);

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions