Skip to content

Remove useMouseIntent in favor of focus-visible - #1157

Merged
dgreif merged 4 commits into
mainfrom
remove-mouse-intent
Apr 15, 2021
Merged

Remove useMouseIntent in favor of focus-visible#1157
dgreif merged 4 commits into
mainfrom
remove-mouse-intent

Conversation

@dgreif

@dgreifdgreif commented Apr 9, 2021

Copy link
Copy Markdown
Contributor

useMouseIntent was manually watching for keyboard/mouse clicks to determine if focus was triggered by the mouse. There is a new CSS pseudo-class, :focus-visible, which exhibits this exact same behavior. Also pulled in the focus-visible polyfill since browser support isn't complete yet.

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

@dgreif
dgreif requested a review from T-HugsApril 9, 2021 18:04
@changeset-bot

changeset-botBot commented Apr 9, 2021•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: eaf89c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/componentsMajor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercelBot commented Apr 9, 2021•
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/BqCatCWg7vQNsDQbkJ64B24oK3ai
✅ Preview: https://primer-components-git-remove-mouse-intent-primer.vercel.app

dgreif
dgreif commented Apr 9, 2021
View reviewed changes
Comment threadsrc/SelectMenu/SelectMenuItem.tsx

// can hover states
@media (hover: hover) {
body:not(.intent-mouse) .SelectMenu-item:focus,

@dgreifdgreifApr 9, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find any instances of the .SelectMenu-item class being used. Possible I overlooked it, but I think this can be removed at this point.

dgreif
dgreif commented Apr 9, 2021
View reviewed changes
Comment threadsrc/index.ts
colebemis
colebemis reviewed Apr 12, 2021
View reviewed changes
Comment threadsrc/BaseStyles.tsx
T-Hugs
T-Hugs approved these changes Apr 13, 2021
View reviewed changes

@T-HugsT-Hugs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dgreif
dgreif enabled auto-merge (squash) April 15, 2021 19:42
@colebemiscolebemis mentioned this pull request Apr 15, 2021
Merged
@dgreif
dgreif merged commit 5f85394 into mainApr 15, 2021
@dgreif
dgreif deleted the remove-mouse-intent branch April 15, 2021 22:45
@github-actionsgithub-actionsBot mentioned this pull request Apr 15, 2021
Merged
@dgreifdgreif mentioned this pull request Jun 27, 2022
Merged
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@daakudaakudaaku left review comments
@colebemiscolebemiscolebemis left review comments
@T-HugsT-HugsT-Hugs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgreif@daaku@T-Hugs@colebemis