DropdownMenu by smockle · Pull Request #1135 · primer/react

smockle · 2021-03-25T19:18:46Z

This is a working branch composed of main, overlay and action-list.

Preview

changeset-bot · 2021-03-25T19:18:48Z

⚠️ No Changeset found

Latest commit: 20ebbe1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2021-03-25T19:18:48Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/9PHTXPcXpPxj7rm3NEkWYtm7DX6j
✅ Preview: https://primer-components-git-dropdownmenu-primer.vercel.app

…ot desired

…ce (indent) by non-selected items

…butes

…ustom Item renderer

… the Overlay open(rendered)/closed(not-rendered) state.

…delint

Co-authored-by: Trevor Gau <trevorsg@gmail.com>

T-Hugs

Mostly minor comments. Overall it looks great; can't wait to get this merged! 🎸

Co-authored-by: Cole Bemis <colebemis@github.com>

T-Hugs

👌 💯 🚀 🎸

colebemis

🎉 🚢

smockle added 3 commits March 25, 2021 11:51

chore: Merge branch 'overlay' into dropdownmenu
2898c3c

chore: Merge branch 'main' into dropdownmenu
ae7841e

feat: Add DropdownMenu
f45dfdb

smockle added 3 commits March 26, 2021 15:13

fix: Don’t hardcode a palette emoji in DropdownMenu; it’s typically n…
98f948e
…ot desired

feat: Enable deselection; draw checks by selected items and empty spa…
bb8e06d
…ce (indent) by non-selected items

feat: Add DropdownButton; begin adding required roles and other attri…
d9576c8
…butes

smockle mentioned this pull request Apr 5, 2021
ActionList #1078
Merged
7 tasks

smockle added 4 commits April 5, 2021 17:30

chore: Merge branch 'main' into dropdownmenu
7bce122

fix: Imported types, plus Storybook warnings, plus debug List-level c…
e3869a7
…ustom Item renderer

fix: Restore 'List'-level custom 'Item' rendering.
b812e73

chore: Merge branch 'main' into dropdownmenu
0cdaab2

dgreif mentioned this pull request Apr 9, 2021
Background styles for focused action list item #1158
Merged
6 tasks

smockleand others added 16 commits April 12, 2021 13:50

chore: Merge 'dropdown-with-zones' into 'dropdownmenu'
007ce3b

fix: keep focus on anchor when dropdown menu opens
16751fb

fix: Rename focus-related state and values to distinguish/dedupe from…
0029c37
… the Overlay open(rendered)/closed(not-rendered) state.

chore: Run Prettier
5edc447

fix: Add 'onDismiss' to the dependency list for 'onAnchorKeyDown' to …
f7bd529
…delint

fix: force render after overlay ref is set
fd369a3

fix(dropdown): treat enter and space on item as an activation
3ec6103

fix: only prevent default if item is activated
ccecdd1

docs: basic docs in dropdown menu
4a545f9

docs: add DropdownMenu docs
6edab5a

chore: add basic tests to DropdownMenu
9b8e9fd

fix: add placeholder value to DropdownMenu
e89cf1e

fix: fix linter by removing unused import
ff6e266

refactor: allow DropdownMenu state to be controlled by parent
275ef22

docs: remove positioning form overlay docs
a789c3f

fix: typescript fixes
9fd1e23

refactor: includes instead of indexOf
7440928
Co-authored-by: Trevor Gau <trevorsg@gmail.com>

T-Hugs reviewed Apr 16, 2021
View reviewed changes

Comment threadsrc/__tests__/Overlay.tsx

T-Hugs reviewed Apr 16, 2021
View reviewed changes

Comment threadsrc/hooks/useFocusTrap.ts Outdated

T-Hugs reviewed Apr 16, 2021
View reviewed changes

Comment threadsrc/hooks/useFocusZone.ts

T-Hugs reviewed Apr 16, 2021
View reviewed changes

Comment threadsrc/DropdownMenu/DropdownMenu.tsx Outdated

T-Hugs suggested changes Apr 16, 2021
View reviewed changes