Uh oh!
There was an error while loading. Please reload this page.
Background styles for focused action list item - #1158
Merged
Conversation
🦋 Changeset detectedLatest commit: 2647438 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/primer/primer-components/GQV7e72mepwCA26ScBsbegfRcxwv |
dgreifforce-pushed
the
action-list-state-backgrounds
branch
2 times, most recently
from
May 19, 2021 21:07
40813d3 to
eea3bb7Comparedgreifforce-pushed
the
action-list-state-backgrounds
branch
from
May 19, 2021 21:20
eea3bb7 to
8ff3d48Comparedgreifforce-pushed
the
action-list-state-backgrounds
branch
from
May 19, 2021 23:24
8ff3d48 to
c5ad77fComparecolebemis
approved these changes
May 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work in #1135 revealed that ActionListItems were not focusable, and when made focusable, their styling was not correct.
tabindex="-1".useFocusZonewill latch onto this and set the tab index to 0 when enabled.Closes#1180
Screenshots
Before
Gray is hover, outline is focused
After
Lighter is hover, darker is focus
Dark Mode
Dark Dimmed Mode
Merge checklist