Skip to content

Use github recommended lint in typescript files - #1167

Merged
dgreif merged 1 commit into
mainfrom
github-recommended-lint
Apr 16, 2021
Merged

Use github recommended lint in typescript files#1167
dgreif merged 1 commit into
mainfrom
github-recommended-lint

Conversation

@dgreif

Copy link
Copy Markdown
Contributor

One more eslint adjustment. The GitHub recommended rules were only being applied in javascript. This adds them to all contexts, and fixes up all the errors that were found.

@dgreif
dgreif requested a review from colebemisApril 15, 2021 21:06
@changeset-bot

changeset-botBot commented Apr 15, 2021

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 01e7148

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercelBot commented Apr 15, 2021

Copy link
Copy Markdown

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/primer/primer-components/C5bgDGrCR4DMHQjixoNWLfr6UATR
✅ Preview: https://primer-components-git-github-recommended-lint-primer.vercel.app

Comment threadsrc/SelectMenu/SelectMenuModal.tsx
@dgreif

Copy link
Copy Markdown
ContributorAuthor

I'm going to wait to merge this until #1135#1152 and #1165 are merged as they will likely have conflicts and I don't want to slow them down

@dgreifdgreif added the 🚧 blocked Someone or something is preventing this from moving forward label Apr 16, 2021
@dgreif
dgreifforce-pushed the github-recommended-lint branch from 51a360c to 01e7148CompareApril 16, 2021 22:48
@dgreifdgreif removed the 🚧 blocked Someone or something is preventing this from moving forward label Apr 16, 2021
@dgreif
dgreif enabled auto-merge (rebase) April 16, 2021 22:49
@dgreif
dgreif merged commit 798cfc4 into mainApr 16, 2021
@dgreif
dgreif deleted the github-recommended-lint branch April 16, 2021 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dgreif@colebemis