Skip to content

Button v2 - Fix font family#1734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pksjce merged 2 commits into from
Dec 15, 2021
+11 −0
Merged

Button v2 - Fix font family #1734

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df7b8df
Add font inherit to NewButton
siddharthkp Dec 14, 2021
35a8c44
Create tiny-cows-fold.md
siddharthkp Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tiny-cows-fold.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Button v2 - Fix font family
1 change: 1 addition & 0 deletions src/NewButton/styles.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -191,6 +191,7 @@ export const getBaseStyles = (theme?: Theme) => ({
borderRadius: '2',
border: '1px solid',
borderColor: theme?.colors.btn.border,
fontFamily: 'inherit',
fontWeight: 'bold',
lineHeight: TEXT_ROW_HEIGHT,
whiteSpace: 'nowrap',
Expand Down
5 changes: 5 additions & 0 deletions src/__tests__/__snapshots__/NewButton.test.tsx.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,7 @@ exports[`Button renders consistently 1`] = `
border-radius: 6px;
border: 1px solid;
border-color: rgba(27,31,36,0.15);
font-family: inherit;
font-weight: 600;
line-height: 20px;
white-space: nowrap;
Expand DownExpand Up@@ -92,6 +93,7 @@ exports[`Button styles danger button appropriately 1`] = `
.c0 {
border-radius: 2;
border: 1px solid;
font-family: inherit;
font-weight: bold;
line-height: 20px;
white-space: nowrap;
Expand DownExpand Up@@ -199,6 +201,7 @@ exports[`Button styles invisible button appropriately 1`] = `
.c0 {
border-radius: 2;
border: 0;
font-family: inherit;
font-weight: bold;
line-height: 20px;
white-space: nowrap;
Expand DownExpand Up@@ -286,6 +289,7 @@ exports[`Button styles outline button appropriately 1`] = `
.c0 {
border-radius: 2;
border: 1px solid;
font-family: inherit;
font-weight: bold;
line-height: 20px;
white-space: nowrap;
Expand DownExpand Up@@ -393,6 +397,7 @@ exports[`Button styles primary button appropriately 1`] = `
border-radius: 2;
border: 1px solid;
border-color: border.subtle;
font-family: inherit;
font-weight: bold;
line-height: 20px;
white-space: nowrap;
Expand Down