Uh oh!
There was an error while loading. Please reload this page.
[Storybook] Remove deprecated components in stories - #2563
Merged
josepmartins merged 10 commits intoNov 11, 2022
Conversation
added 7 commits
November 10, 2022 15:53
🦋 Changeset detectedLatest commit: 20cea00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
langermank
approved these changes
Nov 11, 2022
langermank
left a comment
Contributor
There was a problem hiding this comment.
Wow, this is excellent! Great catch on this.
josepmartins
deleted the
josepmartins/storybook-deprecated-components
branch
November 11, 2022 08:12
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecated component instances as we plan to heavily invest in Storybook and Lookbook as the primary source for code documentation.
Related: https://github.com/github/primer/issues/1375
Similar PR: #2555
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.