Uh oh!
There was an error while loading. Please reload this page.
UnderlineNav2: expose aria-current in the API and enable to use it for select status - #2618
Merged
Conversation
🦋 Changeset detectedLatest commit: 0983b76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
broccolinisoup
marked this pull request as ready for review
November 28, 2022 02:39
broccolinisoupforce-pushed
the
UnderlineNav-aria-current
branch
from
November 28, 2022 23:27
02407f6 to
0cafcd7Comparebroccolinisoupforce-pushed
the
UnderlineNav-aria-current
branch
from
November 29, 2022 00:15
0cafcd7 to
989520bComparecolebemis
approved these changes
Nov 29, 2022
colebemis
left a comment
Contributor
There was a problem hiding this comment.
Looks great! Nice work on this, @broccolinisoup 💖
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Cole Bemis <colebemis@github.com>
Merged
This was referenced Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is mainly created for API consistency purposes between
NavListandUnderlineNav v2.UnderlineNavwas usingselectedprop for the selectedUnderlineNav.ItemwhereasNavListdoes the same thing with aria-current. This PR exposesaria-currentattribute in the API for managing its selected state.Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.