Skip to content

UnderlineNav2: Update React router docs and add Next.js docs - #2627

Merged
broccolinisoup merged 4 commits into
mainfrom
UnderlineNav-docs-update
Dec 1, 2022
Merged

UnderlineNav2: Update React router docs and add Next.js docs#2627
broccolinisoup merged 4 commits into
mainfrom
UnderlineNav-docs-update

Conversation

@broccolinisoup

@broccolinisoupbroccolinisoup commented Nov 30, 2022•
edited
Loading

Copy link
Copy Markdown
Member

This PR updates React Router docs after the change in API and adds Next.js docs.

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@changeset-bot

changeset-botBot commented Nov 30, 2022•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 54878c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Nov 30, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js78.95 KB (0%)
dist/browser.umd.js79.58 KB (0%)

@broccolinisoup
broccolinisoup temporarily deployed to github-pages November 30, 2022 04:10 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2627 November 30, 2022 04:10 Inactive
@broccolinisoupbroccolinisoup added the skip changeset This change does not need a changelog label Nov 30, 2022
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2627 November 30, 2022 05:24 Inactive
@broccolinisoup
broccolinisoup temporarily deployed to github-pages November 30, 2022 05:25 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2627 November 30, 2022 05:25 Inactive
@broccolinisoup
broccolinisoup temporarily deployed to github-pages December 1, 2022 02:00 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-2627 December 1, 2022 02:00 Inactive
@broccolinisoup
broccolinisoup marked this pull request as ready for review December 1, 2022 09:14
@broccolinisoup
broccolinisoup requested review from a team and langermankDecember 1, 2022 09:14
josepmartins
josepmartins approved these changes Dec 1, 2022•
edited
Loading
View reviewed changes
josepmartins
josepmartins approved these changes Dec 1, 2022
View reviewed changes

@josepmartinsjosepmartins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! just left a couple of non-blocking comments

Comment threaddocs/content/drafts/UnderlineNav2.mdx
Comment threaddocs/content/drafts/UnderlineNav2.mdx
@broccolinisoup
broccolinisoup enabled auto-merge (squash) December 1, 2022 21:00
@broccolinisoup
broccolinisoup temporarily deployed to github-pages December 1, 2022 21:05 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-2627 December 1, 2022 21:06 Inactive
@broccolinisoup
broccolinisoup merged commit fa43979 into mainDec 1, 2022
@broccolinisoup
broccolinisoup deleted the UnderlineNav-docs-update branch December 1, 2022 21:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@langermanklangermankAwaiting requested review from langermank
1 more reviewer
@josepmartinsjosepmartinsjosepmartins approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@broccolinisoup@josepmartins