Skip to content

ActionList: Fix icon and description hover color for danger variant - #3045

Closed
siddharthkp wants to merge 11 commits into
mainfrom
repro-actionlist-danger
Closed

ActionList: Fix icon and description hover color for danger variant#3045
siddharthkp wants to merge 11 commits into
mainfrom
repro-actionlist-danger

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Mar 16, 2023

Copy link
Copy Markdown
Member

@changeset-bot

This comment was marked as outdated.

@siddharthkpsiddharthkp added the skip changeset This change does not need a changelog label Mar 16, 2023
@github-actions

github-actionsBot commented Mar 16, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js95.19 KB (+0.06% 🔺)
dist/browser.umd.js95.76 KB (+0.05% 🔺)

@siddharthkp
siddharthkp temporarily deployed to github-pages March 16, 2023 17:28 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 16, 2023 17:28 Inactive
@siddharthkpsiddharthkp changed the title ActionList stories: Add variant for danger in all combinationsActionList: Fix icon and description color for dangerMar 20, 2023
@siddharthkpsiddharthkp changed the title ActionList: Fix icon and description color for dangerActionList: Fix icon and description hover color for danger variantMar 20, 2023
@siddharthkpsiddharthkp self-assigned this Mar 20, 2023
@siddharthkpsiddharthkp removed the skip changeset This change does not need a changelog label Mar 20, 2023
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 20, 2023 13:07 Inactive
@siddharthkp
siddharthkp marked this pull request as ready for review March 20, 2023 13:08
@siddharthkp
siddharthkp requested review from a team and JoshBowdenConceptsMarch 20, 2023 13:08
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 20, 2023 13:12 Inactive
@siddharthkp
siddharthkp temporarily deployed to github-pages March 20, 2023 13:12 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 20, 2023 13:12 Inactive
@siddharthkp
siddharthkp temporarily deployed to github-pages March 20, 2023 13:26 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 20, 2023 13:27 Inactive
@siddharthkp
siddharthkp temporarily deployed to github-pages March 20, 2023 15:08 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 20, 2023 15:09 Inactive

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@siddharthkp
siddharthkp requested review from joshblack and removed request for JoshBowdenConceptsMarch 20, 2023 15:43

@joshblackjoshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left a comment for the @aat stuff, should be good to go after updating the snapshots 👍

Comment threade2e/components/ActionList.test.ts Outdated
Co-authored-by: Josh Black <joshblack@github.com>
@siddharthkp
siddharthkp temporarily deployed to github-pages March 21, 2023 16:06 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 21, 2023 16:06 Inactive
@siddharthkp
siddharthkp temporarily deployed to github-pages March 29, 2023 15:10 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 March 29, 2023 16:16 Inactive
@siddharthkpsiddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 6, 2023
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 6, 2023
@primer
primerBot temporarily deployed to github-pages April 6, 2023 12:19 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3045 April 6, 2023 12:20 Inactive
@siddharthkpsiddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 6, 2023
@github-actions
github-actionsBottemporarily deployed to storybook-preview-3045 April 6, 2023 12:52 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 6, 2023
@langermank

Copy link
Copy Markdown
Contributor

@siddharthkp what's the latest on this? Is it good to merge?

@github-actions

Copy link
Copy Markdown
Contributor

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.

@siddharthkp

Copy link
Copy Markdown
MemberAuthor

Replaced by #3505

@siddharthkp
siddharthkp deleted the repro-actionlist-danger branch December 7, 2023 13:32
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp@langermank@joshblack