Skip to content

Button: Fix storybook playground, add missing e2e tests - #3226

Merged
siddharthkp merged 9 commits into
mainfrom
prep-css-button
Apr 28, 2023
Merged

Button: Fix storybook playground, add missing e2e tests#3226
siddharthkp merged 9 commits into
mainfrom
prep-css-button

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Apr 26, 2023

Copy link
Copy Markdown
Member

Breaking #3065 into small parts to make PRs easier to maintain and review

  • fix Button playground
  • fix drafts/Button metadata
  • remove IconButton and LinkButton from drafts (they will come later)
  • add missing stories to e2e tests

@changeset-bot

This comment was marked as outdated.

@siddharthkpsiddharthkp self-assigned this Apr 26, 2023
@siddharthkpsiddharthkp added skip changeset This change does not need a changelog update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Apr 26, 2023
@github-actions

github-actionsBot commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js121.18 KB (0%)
dist/browser.umd.js121.47 KB (0%)

@github-actions
github-actionsBot temporarily deployed to storybook-preview-3226 April 26, 2023 13:36 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Apr 26, 2023
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3226 April 26, 2023 13:39 Inactive
@siddharthkp
siddharthkp marked this pull request as ready for review April 26, 2023 13:40
@siddharthkp
siddharthkp requested a review from a teamApril 26, 2023 13:40
@primer
primerBot temporarily deployed to github-pages April 26, 2023 13:43 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3226 April 26, 2023 13:44 Inactive
@siddharthkp
siddharthkp temporarily deployed to github-pages April 26, 2023 14:18 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3226 April 26, 2023 14:19 Inactive
@siddharthkp
siddharthkp added this pull request to the merge queueApr 28, 2023
@siddharthkpsiddharthkp changed the title Prep for css ButtonInternal: Button: Fix storybook playground, add e2e testsApr 28, 2023
@siddharthkpsiddharthkp changed the title Internal: Button: Fix storybook playground, add e2e testsButton: Fix storybook playground, add e2e testsApr 28, 2023
@siddharthkpsiddharthkp changed the title Button: Fix storybook playground, add e2e testsButton: Fix storybook playground, add missing e2e testsApr 28, 2023
Merged via the queue into main with commit ee4e6d1Apr 28, 2023
@siddharthkp
siddharthkp deleted the prep-css-button branch April 28, 2023 14:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@colebemis