Uh oh!
There was an error while loading. Please reload this page.
Storybook & build setup for css - #3227
Conversation
siddharthkp
commented
Apr 26, 2023
- Follow up for Button: Fix storybook playground, add missing e2e tests #3226
- Subset of Spike: Button with css #3065
This comment was marked as outdated.
This comment was marked as outdated.
size-limit report 📦
|
| background-color: tomato; | ||
| color: white; | ||
| width: fit-content; | ||
| padding: 0.625rem 0.75rem; |
There was a problem hiding this comment.
not using primer/primitives yet, will create another follow up PR for that!
(theming setup with primitives deserves it's own PR)
There was a problem hiding this comment.
Happy to pair or collab async on this!
| import merge from 'classnames' | ||
| import classNames from './component.module.css' | ||
| export const Component: React.FC<React.HTMLProps<HTMLDivElement>> = ({className, ...props}) => { |
There was a problem hiding this comment.
What purpose does this component serve?
There was a problem hiding this comment.
No purpose to the user, I added this as a temporary component to show in storybook and to build with rollup
There was a problem hiding this comment.
Isn't that what Button2 was for?
There was a problem hiding this comment.
Yep, that PR became too messy to maintain, so I wanted to set up a generic dev environment, before getting into Button specifics in a new PR
Next 2 PRs after this one would be:
- theming with primitives
- Button component
Would you prefer reviewing these changes with the context of Button instead?
joshblack
left a comment
There was a problem hiding this comment.
🥳 Just left a couple of questions, excited to see this get started!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.