Refactor FilteredActionList to address a11y violations and use new ActionList.

[radglob]

The FilteredActionList (and by extension SelectPanel) use the updated ActionList component.

Added a hideSelection prop that allows us to hide the Selection component that usually renders when an ActionList has a selectionVariant defined. The dropdown in the MarkdownEditor's saved replies did not show this previously, so this was added to keep the appearance the same.

Closeshttps://github.com/github/primer/issues/1861

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 4740613

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	101.6 KB (+0.12% 🔺)
dist/browser.umd.js	102.16 KB (+0.15% 🔺)

[colebemis]

@radglob Does this PR entirely close https://github.com/github/primer/issues/1861? It seems like it only address part of the issue:

• The ActionList used in this component is deprecated and may need to be updated

I don't see code changes to address this items:

• The aria-input-field-name rule corresponds to the item with role="listbox" which has no accessible label
• This component seems to follow a combobox interaction pattern and requires a visible label for the input. The combobox pattern may address aria-input-field-name by providing aria-labelledby on the listbox pointed towards the input
• The item with role="listbox" must have items with role="option"
• This component may require a visual label which would mean design needs to be included in this issue

[siddharthkp]

Final comments:

• backward compatibility for showItemDividers
• checking if there are no other backward breaking changes

Approving in advance

[radglob]

@radglob Does this PR entirely close github/primer#1861? It seems like it only address part of the issue:

• The ActionList used in this component is deprecated and may need to be updated

I don't see code changes to address this items:

• The aria-input-field-name rule corresponds to the item with role="listbox" which has no accessible label
• This component seems to follow a combobox interaction pattern and requires a visible label for the input. The combobox pattern may address aria-input-field-name by providing aria-labelledby on the listbox pointed towards the input
• The item with role="listbox" must have items with role="option"
• This component may require a visual label which would mean design needs to be included in this issue

Great point. I think I got mired in other issues and need to circle back to those. Should be easy enough to fix now that technical concerns are out of the way.

[radglob]

@radglob Does this PR entirely close github/primer#1861? It seems like it only address part of the issue:

• The ActionList used in this component is deprecated and may need to be updated

I don't see code changes to address this items:

• The aria-input-field-name rule corresponds to the item with role="listbox" which has no accessible label
• This component seems to follow a combobox interaction pattern and requires a visible label for the input. The combobox pattern may address aria-input-field-name by providing aria-labelledby on the listbox pointed towards the input
• The item with role="listbox" must have items with role="option"
• This component may require a visual label which would mean design needs to be included in this issue

Great point. I think I got mired in other issues and need to circle back to those. Should be easy enough to fix now that technical concerns are out of the way.

These are actually fixed. I think I was looking at a stale local storybook instance.