Skip to content

Add fixtures for #3044 - #3504

Merged
siddharthkp merged 3 commits into
mainfrom
fixtures-3044
Jul 10, 2023
Merged

Add fixtures for #3044#3504
siddharthkp merged 3 commits into
mainfrom
fixtures-3044

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Jul 10, 2023•
edited
Loading

Copy link
Copy Markdown
Member

Add fixtures for #3044

leading icon and background have the same color, which makes the icon disappear, description does not have enough contrast with the background

@siddharthkpsiddharthkp added the skip changeset This change does not need a changelog label Jul 10, 2023
@siddharthkp
siddharthkp requested a review from a teamJuly 10, 2023 10:16
@siddharthkpsiddharthkp self-assigned this Jul 10, 2023
@changeset-bot

changeset-botBot commented Jul 10, 2023•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b83e0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkpsiddharthkp added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 10, 2023
@github-actions

github-actionsBot commented Jul 10, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
dist/browser.esm.js102.31 KB (0%)
dist/browser.umd.js102.88 KB (0%)

@siddharthkp
siddharthkp temporarily deployed to github-pages July 10, 2023 10:22 — with GitHub Actions Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3504 July 10, 2023 10:23 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 10, 2023
@primer
primerBot temporarily deployed to github-pages July 10, 2023 10:32 Inactive
@github-actions
github-actionsBot temporarily deployed to storybook-preview-3504 July 10, 2023 10:32 Inactive
siddharthkp
siddharthkp commented Jul 10, 2023
View reviewed changes

@siddharthkpsiddharthkp left a comment •
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated snapshots!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-3504 July 10, 2023 10:51 Inactive
@siddharthkpsiddharthkp mentioned this pull request Jul 10, 2023
Merged
@siddharthkp
siddharthkp added this pull request to the merge queueJul 10, 2023
Merged via the queue into main with commit 4a70ce3Jul 10, 2023
@siddharthkp
siddharthkp deleted the fixtures-3044 branch July 10, 2023 15:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes

Assignees

@siddharthkpsiddharthkp

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@joshblack