Replace deprecated Button in Dialog

[TylerJDev]

Closeshttps://github.com/github/primer/issues/2470, #3062

Changelog

Changed

Replaces deprecated Button component in Dialog.tsx with newest version.

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

For a successful rollout in github, we'll need to adjust some items that rely on the deprecated version of Button. The changes needed can be viewed in the integration test PR.

Testing & Reviewing

Ensure that a focus indicator is present when focused on any of the dialog's footer buttons.

Dialog default Storybook example.

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

🦋 Changeset detected

Latest commit: 61df519

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.71 KB (-0.8% 🔽)
dist/browser.umd.js	105.27 KB (-0.82% 🔽)

[joshblack]

These changes look great to me and the upstream PR makes it seem like we only need to update tests 💯 I'll also request @broccolinisoup who I think may also have some helpful context for migrating this work if I remember right (I think she had helped an outside contributor trying to do this in the past and I wasn't sure what the hiccups ended up being there)

[broccolinisoup]

These changes look great to me and the upstream PR makes it seem like we only need to update tests 💯 I'll also request @broccolinisoup who I think may also have some helpful context for migrating this work if I remember right (I think she had helped an outside contributor trying to do this in the past and I wasn't sure what the hiccups ended up being there)

Thanks @joshblack for the ping, I appreciate it! We chatted about it in our call with Tyler and the reason that we reverted this PR is addressed in the integration PR 🤗 And the solution is approved by the code owners. Seems like we are good to go!

[broccolinisoup]

Looks great! Thank you so much for fixing that and providing the integration fixes as well ✨