Uh oh!
There was an error while loading. Please reload this page.
ButtonGroup: Fix button and icon button styling when tooltips are used on them - #4210
Conversation
🦋 Changeset detectedLatest commit: f427dfd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
Uh oh!
There was an error while loading. Please reload this page.
f04ef75 to
3b0c065Compare| </ButtonGroup> | ||
| ) | ||
| export const IconButtonsWithTooltip = () => ( |
There was a problem hiding this comment.
Happy to remove them after the review if we don't want to keep them
langermank
left a comment
There was a problem hiding this comment.
Just one small question, otherwise looks good 👍
| </ButtonGroup> | ||
| ) | ||
| export const IconButtonsWithTooltip = () => ( |
| isolation: isolate; | ||
| && > * { | ||
| && > button, |
There was a problem hiding this comment.
@broccolinisoup is it possible these could be a tags as well? You could add a test story case for that and see.
There was a problem hiding this comment.
Oo great catch @langermank! Definitely, they can be a tags. I'll update the code.
This comment was marked as off-topic.
This comment was marked as off-topic.
…d on them (#4210) * fix button group styling for tooltip and tooltip v2 * Add changeset * take the a tag into account when styling * add e2e tests for the buttons groups that use tooltip * test(vrt): update snapshots --------- Co-authored-by: broccolinisoup <broccolinisoup@users.noreply.github.com>
Closes#4129
Changelog
New
Changed
Updated Button group CSS to make sure the icon buttons and buttons are rendered as expected when they have tooltips (both v1 and v2) on them
Removed
Rollout strategy
Testing & Reviewing
Merge checklist