Skip to content

ButtonGroup: Fix button and icon button styling when tooltips are used on them - #4371

Closed
broccolinisoup wants to merge 23 commits into
mainfrom
explore-wrapping-button-group-items
Closed

ButtonGroup: Fix button and icon button styling when tooltips are used on them#4371
broccolinisoup wants to merge 23 commits into
mainfrom
explore-wrapping-button-group-items

Conversation

@broccolinisoup

@broccolinisoupbroccolinisoup commented Mar 8, 2024

Copy link
Copy Markdown
Member

Closes#4129

Changelog

New

Changed

  • With this PR, we are wrapping button group items with a div. The main reason is to simplify CSS selection. You can view the previous attempt to write a CSS to fix styling issues both for tooltip v1 and v2 on button group.
  • Enhanced CSS selection for the ButtonGroup children elements to ensure buttons and links still look the same if there are tooltips on them

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@broccolinisoupbroccolinisoup added the skip changeset This change does not need a changelog label Mar 8, 2024
@changeset-bot

changeset-botBot commented Mar 8, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ea8b026

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actionsBot commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js91.23 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js91.48 KB (-0.03% 🔽)

@primer-integration

primer-integrationBot commented Jul 1, 2024

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/331337

@broccolinisoupbroccolinisoup changed the title Explore wrapping button group items with a div to simplify css selectionButtonGroup: Fix button and icon button styling when tooltips are used on themJul 3, 2024
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 3, 2024
@primer
primerBottemporarily deployed to github-pages July 3, 2024 03:08 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4371 July 3, 2024 03:08 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4371 July 3, 2024 23:46 Inactive
@broccolinisoupbroccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 4, 2024
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 4, 2024
@primer
primerBottemporarily deployed to github-pages July 4, 2024 05:32 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4371 July 4, 2024 05:33 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4371 July 4, 2024 23:44 Inactive
@broccolinisoupbroccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 5, 2024
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Jul 5, 2024
@primer
primerBottemporarily deployed to github-pages July 5, 2024 01:08 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4371 July 5, 2024 01:08 Inactive
@broccolinisoup

Copy link
Copy Markdown
MemberAuthor

closing in favour of #4723

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using <Tooltip> within <ButtonGroup> affects styling

1 participant

@broccolinisoup