Skip to content

Update README.md - #4393

Merged
langermank merged 3 commits into
mainfrom
maximedegreve-patch-1
Apr 11, 2024
Merged

Update README.md#4393
langermank merged 3 commits into
mainfrom
maximedegreve-patch-1

Conversation

@maximedegreve

Copy link
Copy Markdown
Contributor

We wanted to make our template more discoverable to avoid that internal employees have to set up their own project and run into unexpected issues.

We want to make our template more discoverable.
- [💬 Internal Slack thread](https://github.slack.com/archives/C02NUUQ9C30/p1710415630143979)
@maximedegreve
maximedegreve requested a review from a team as a code ownerMarch 14, 2024 18:59
@changeset-bot

changeset-botBot commented Mar 14, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 2dc9dcb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Mar 14, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js87.51 KB (0%)
packages/react/dist/browser.umd.js87.74 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4393 March 14, 2024 19:02 Inactive
@@ -0,0 +1,5 @@
---
"@primer/react": patch

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We usually release the docs changes without a changeset but did you want to announce this in the release notes?

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my plan. I was getting a warning though because there wasn't a changeset?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah the CI job will fail if there is no changeset. You could either add a changeset like you did here or you can add skip changeset label.

Comment threadREADME.md Outdated
Co-authored-by: Owen Niblock <owenniblock@github.com>
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4393 March 17, 2024 19:15 Inactive
@langermank
langermank added this pull request to the merge queueApr 11, 2024
Merged via the queue into main with commit 57e1742Apr 11, 2024
@langermank
langermank deleted the maximedegreve-patch-1 branch April 11, 2024 22:41
@primerprimerBot mentioned this pull request Apr 11, 2024
@liuliu-devliuliu-dev mentioned this pull request Jul 10, 2025
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@maximedegreve@broccolinisoup@owenniblock@langermank