Skip to content

Add basic link styles to BaseStyles - #6314

Merged
liuliu-dev merged 11 commits into
mainfrom
liuliu/add-link-color-to-basestyle
Jul 14, 2025
Merged

Add basic link styles to BaseStyles#6314
liuliu-dev merged 11 commits into
mainfrom
liuliu/add-link-color-to-basestyle

Conversation

@liuliu-dev

@liuliu-devliuliu-dev commented Jul 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Adds basic link styling (color and hover states) to BaseStyles to provide consistent link appearance without requiring additional CSS imports.

Related:

Closes#4393

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

CopilotAI review requested due to automatic review settings July 10, 2025 20:09
@liuliu-dev
liuliu-dev requested a review from a team as a code ownerJuly 10, 2025 20:09
@changeset-bot

changeset-botBot commented Jul 10, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ccd8ecd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jul 10, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jul 10, 2025
CopilotAI reviewed Jul 10, 2025
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds basic link styling to the BaseStyles component to provide consistent link appearance across the design system without requiring additional CSS imports. The changes establish default color and hover behavior for anchor elements using design tokens.

  • Adds global link styles with accent color and hover underline effects
  • Includes proper changeset documentation for patch release

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

FileDescription
packages/react/src/BaseStyles.module.cssAdds global anchor element styles with color tokens and hover states
.changeset/tidy-drinks-speak.mdDocuments the change for patch release versioning

Comment threadpackages/react/src/BaseStyles.module.css Outdated
Comment threadpackages/react/src/BaseStyles.module.css
@github-actions

github-actionsBot commented Jul 10, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js92.01 KB (0%)
packages/react/dist/browser.umd.js92.29 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 20:19 Inactive
@liuliu-dev
liuliu-dev marked this pull request as draft July 10, 2025 20:26
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 20:29 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 21:18 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 22:53 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 23:07 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 23:16 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 10, 2025 23:23 Inactive
@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jul 10, 2025
@liuliu-dev
liuliu-dev marked this pull request as ready for review July 11, 2025 16:21
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Jul 11, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 11, 2025 18:03 Inactive
@liuliu-dev
liuliu-dev marked this pull request as draft July 11, 2025 20:59
@github-actions
github-actionsBot requested a deployment to storybook-preview-6314 July 11, 2025 21:56 Abandoned
@primer-integration

primer-integrationBot commented Jul 11, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/390349

@github-actions
github-actionsBottemporarily deployed to storybook-preview-6314 July 11, 2025 22:09 Inactive
@primer-integration

primer-integrationBot commented Jul 11, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jul 11, 2025
@liuliu-dev
liuliu-dev marked this pull request as ready for review July 11, 2025 22:40
hectahertz
hectahertz approved these changes Jul 14, 2025
View reviewed changes

@hectahertzhectahertz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a nice approach! ✨

@liuliu-dev
liuliu-dev added this pull request to the merge queueJul 14, 2025
Merged via the queue into main with commit a5a0afeJul 14, 2025
@liuliu-dev
liuliu-dev deleted the liuliu/add-link-color-to-basestyle branch July 14, 2025 17:08
@primerprimerBot mentioned this pull request Jul 14, 2025
Merged
llastflowers pushed a commit that referenced this pull request Jul 23, 2025
@liuliu-dev@llastflowers
Add basic link styles to BaseStyles (#6314)
8fc14e5
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@hectahertzhectahertzhectahertz approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liuliu-dev@hectahertz