Uh oh!
There was an error while loading. Please reload this page.
Adds aria-expanded="false" back to AnchoredOverlay - #4394
Merged
Conversation
🦋 Changeset detectedLatest commit: 7cc9d42 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblack
approved these changes
Mar 15, 2024
Merged
siddharthkp added a commit
that referenced
this pull request
Apr 2, 2024
This reverts commit cc9b98a.
lukasoppermann pushed a commit
that referenced
this pull request
Apr 16, 2024
* Adds `aria-expanded="false"` back to `AnchoredOverlay` * Add changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will resolve: https://github.com/github/accessibility-audits/issues/6932
We have an open accessibility issue related to how we handle
aria-expandedwithinAnchoredOverlay. We did not applyaria-expandedwhen a menu was open since it was redundant, and it was very unlikely that there'd be navigation outside of the menu before it was closed. We've received feedback that this may cause an unintended effect for users using specific devices/AT that makes it difficult to leave the menu.Changelog
Changed
aria-expandedstate toAnchoredOverlay.Rollout strategy
Testing & Reviewing
Merge checklist