Skip to content

Revert "Adds aria-expanded="false" back to AnchoredOverlay" - #4455

Merged
siddharthkp merged 1 commit into
mainfrom
revert-4394-tylerjdev/add-aria-expanded-state
Apr 2, 2024
Merged

Revert "Adds aria-expanded="false" back to AnchoredOverlay"#4455
siddharthkp merged 1 commit into
mainfrom
revert-4394-tylerjdev/add-aria-expanded-state

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Apr 2, 2024

Copy link
Copy Markdown
Member

The failures are of 2 kinds:

  1. failing storybook axe tests: (example) These errors are related to incorrect usage. There are some triggers that are not buttons, adding an aria-expanded to them leads to axe errors. We need to fix the incorrect usage first.
  2. failing jest tests: (example) There are tests that expect aria-expanded to be undefined instead of false. We need to update these tests in a branch that we can merge into the integration branch

Next steps:

  1. After this PR is merged, please revert this pull request to bring back your changes in a new PR.
  2. Mark as ready to review once you have tested with dotcom

How to we avoid reverts like this in the future?

Follow this guide to run integration tests for your pull request in dotcom: https://github.com/github/primer-engineering/blob/main/how-we-work/testing-primer-react-pr-at-dotcom.md

@siddharthkpsiddharthkp self-assigned this Apr 2, 2024
@siddharthkp
siddharthkp requested a review from a team as a code ownerApril 2, 2024 13:57
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3228b7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js88.97 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js89.25 KB (-0.04% 🔽)

@siddharthkp
siddharthkp removed the request for review from joshblackApril 2, 2024 14:52
@siddharthkp
siddharthkp added this pull request to the merge queueApr 2, 2024
Merged via the queue into main with commit 06f57f4Apr 2, 2024
@siddharthkp
siddharthkp deleted the revert-4394-tylerjdev/add-aria-expanded-state branch April 2, 2024 15:03
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@TylerJDev