Skip to content

chore: remove TabPanels component - #4804

Merged
joshblack merged 5 commits into
mainfrom
3692-remove-tabpanels-component
Aug 16, 2024
Merged

chore: remove TabPanels component#4804
joshblack merged 5 commits into
mainfrom
3692-remove-tabpanels-component

Conversation

@joshblack

@joshblackjoshblack commented Jul 31, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/primer/issues/3692

Changelog

New

Changed

Removed

  • Remove TabPanels component from experimental, drafts entrypoints

Rollout strategy

  • Minor release

Marking this as minor since this is an experimental component

Testing & Reviewing

  • Verify that TabPanels is no longer exported
  • Verify that TabPanels does not show up in storybook
  • Verify that TabPanels is not in our docs sub-site

@changeset-bot

changeset-botBot commented Jul 31, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 0d87c46

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jul 31, 2024
@github-actions

github-actionsBot commented Jul 31, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js95.8 KB (0%)
packages/react/dist/browser.umd.js96.19 KB (0%)

@joshblack
joshblack marked this pull request as ready for review August 7, 2024 16:11
@joshblack
joshblack requested review from a team as code ownersAugust 7, 2024 16:11
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4804 August 7, 2024 16:16 Inactive
@joshblack

joshblack commented Aug 9, 2024

Copy link
Copy Markdown
MemberAuthor

bump @broccolinisoup@mperrotti !

broccolinisoup
broccolinisoup approved these changes Aug 12, 2024
View reviewed changes

@broccolinisoupbroccolinisoup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a comment about the changeset, let me know what you think!

Comment thread.changeset/forty-ants-tell.md
'@primer/react': minor
---

Remove experimental TabPanels component in preference of UnderlinePanels

@broccolinisoupbroccolinisoupAug 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, we don't have an internal usage for this component but I am wondering in case for open source usages should we release this as "potentially major"?

@joshblackjoshblackAug 12, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'm honestly not sure 🤷 It'd be great if we wouldn't even need to do a semver bump for this since it's under experimental/drafts but it's clearly nice to know if one of these things get removed. I think because of that I'm torn since we definitely don't want these to be considered under semver but it's also nice to communicate this stuff 😕

This is where the minor bump came from just to say that things are changing but happy to say major to make this simpler 👍

@broccolinisoupbroccolinisoupAug 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is draft!! Sorry I missed that. Yeah no worries. minor sounds good then.

@joshblack
joshblack enabled auto-merge August 14, 2024 21:57
@joshblack

joshblack commented Aug 14, 2024

Copy link
Copy Markdown
MemberAuthor

bump @mperrotti when you have a sec!

@joshblack
joshblack added this pull request to the merge queueAug 16, 2024
Merged via the queue into main with commit fd2c705Aug 16, 2024
@joshblack
joshblack deleted the 3692-remove-tabpanels-component branch August 16, 2024 17:45
@primerprimerBot mentioned this pull request Aug 16, 2024
Merged
@primerprimerBot mentioned this pull request Oct 18, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupbroccolinisoup approved these changes
@mperrottimperrottiAwaiting requested review from mperrottimperrotti was automatically assigned from primer/design-reviewers
+1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

staffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshblack@broccolinisoup@langermank