Skip to content

chore: remove TabPanels component#4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshblack merged 5 commits into from
Aug 16, 2024
Merged

chore: remove TabPanels component #4804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6511fb8
chore: remove TabPanels component
joshblack Jul 31, 2024
20f4b90
test(e2e): remove e2e tests for Tabpanels
joshblack Jul 31, 2024
0ea4c00
docs: remove TabPanels docs
joshblack Aug 7, 2024
02661e5
chore: add changeset
joshblack Aug 7, 2024
0d87c46
Merge branch 'main' into 3692-remove-tabpanels-component
joshblack Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/forty-ants-tell.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
'@primer/react': minor
---

Remove experimental TabPanels component in preference of UnderlinePanels

@broccolinisoupbroccolinisoupAug 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand, we don't have an internal usage for this component but I am wondering in case for open source usages should we release this as "potentially major"?

@joshblackjoshblackAug 12, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'm honestly not sure 🤷 It'd be great if we wouldn't even need to do a semver bump for this since it's under experimental/drafts but it's clearly nice to know if one of these things get removed. I think because of that I'm torn since we definitely don't want these to be considered under semver but it's also nice to communicate this stuff 😕

This is where the minor bump came from just to say that things are changing but happy to say major to make this simpler 👍

@broccolinisoupbroccolinisoupAug 12, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is draft!! Sorry I missed that. Yeah no worries. minor sounds good then.

Binary file removed...ponents/TabPanels.test.ts-snapshots/TabPanels-Default-dark-colorblind-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed.../components/TabPanels.test.ts-snapshots/TabPanels-Default-dark-dimmed-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...ents/TabPanels.test.ts-snapshots/TabPanels-Default-dark-high-contrast-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...apshots/components/TabPanels.test.ts-snapshots/TabPanels-Default-dark-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...ponents/TabPanels.test.ts-snapshots/TabPanels-Default-dark-tritanopia-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...onents/TabPanels.test.ts-snapshots/TabPanels-Default-light-colorblind-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...nts/TabPanels.test.ts-snapshots/TabPanels-Default-light-high-contrast-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...pshots/components/TabPanels.test.ts-snapshots/TabPanels-Default-light-linux.png
View file
Open in desktop
Binary file not shown.
Binary file removed...onents/TabPanels.test.ts-snapshots/TabPanels-Default-light-tritanopia-linux.png
View file
Open in desktop
Binary file not shown.
33 changes: 0 additions & 33 deletions docs/content/drafts/TabPanels.mdx
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions e2e/components/TabPanels.test.ts
View file
Open in desktop

This file was deleted.

8 changes: 0 additions & 8 deletions packages/react/src/__tests__/__snapshots__/exports.test.ts.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -344,10 +344,6 @@ exports[`@primer/react/drafts should not update exports without a semver change
"type TableRowProps",
"type TableSubtitleProps",
"type TableTitleProps",
"TabPanels",
"type TabPanelsPanelProps",
"type TabPanelsProps",
"type TabPanelsTabProps",
"type TitleProps",
"Tooltip",
"TooltipContext",
Expand DownExpand Up@@ -460,10 +456,6 @@ exports[`@primer/react/experimental should not update exports without a semver c
"type TableRowProps",
"type TableSubtitleProps",
"type TableTitleProps",
"TabPanels",
"type TabPanelsPanelProps",
"type TabPanelsProps",
"type TabPanelsTabProps",
"type TitleProps",
"Tooltip",
"TooltipContext",
Expand Down
79 changes: 0 additions & 79 deletions packages/react/src/drafts/TabPanels/TabPanels.docs.json
View file
Open in desktop

This file was deleted.

98 changes: 0 additions & 98 deletions packages/react/src/drafts/TabPanels/TabPanels.features.stories.tsx
View file
Open in desktop

This file was deleted.

51 changes: 0 additions & 51 deletions packages/react/src/drafts/TabPanels/TabPanels.stories.tsx
View file
Open in desktop

This file was deleted.

Loading