Skip to content

SelectPanel: Add stories and tests for documentation purposes - #4829

Merged
broccolinisoup merged 13 commits into
mainfrom
select-panel-story-and-tests
Aug 12, 2024
Merged

SelectPanel: Add stories and tests for documentation purposes#4829
broccolinisoup merged 13 commits into
mainfrom
select-panel-story-and-tests

Conversation

@broccolinisoup

@broccolinisoupbroccolinisoup commented Aug 8, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Changelog

New

  • Added stories for undocumented features such as groups etc

Changed

  • Reorganised the stories based on our recent conventions
  • Re-exported the deprecated ActionList types from SelectPanel

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Aug 8, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6170f77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Aug 8, 2024
@github-actions

github-actionsBot commented Aug 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.2 KB (0%)
packages/react/dist/browser.umd.js96.46 KB (0%)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 8, 2024 02:46 Inactive
@broccolinisoupbroccolinisoup added the skip changeset This change does not need a changelog label Aug 8, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 8, 2024 03:01 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 8, 2024 06:45 Inactive
@broccolinisoup
broccolinisoup marked this pull request as ready for review August 8, 2024 06:51
@broccolinisoup
broccolinisoup requested a review from a team as a code ownerAugust 8, 2024 06:51
broccolinisoup
broccolinisoup commented Aug 8, 2024
View reviewed changes
Comment threadpackages/react/src/SelectPanel/SelectPanel.stories.tsx
siddharthkp
siddharthkp reviewed Aug 9, 2024
View reviewed changes
Comment threadpackages/react/src/SelectPanel/SelectPanel.tsx
siddharthkp
siddharthkp reviewed Aug 9, 2024
View reviewed changes
Comment threadpackages/react/src/FilteredActionList/FilteredActionList.tsx
import {get} from '../constants'
import {ActionList} from '../deprecated/ActionList'
import type {GroupedListProps, ListPropsBase} from '../deprecated/ActionList/List'
import type {GroupedListProps, ListPropsBase} from '../SelectPanel/types'

@siddharthkpsiddharthkpAug 9, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(non blocker) Should we bring FilteredActionList into src/SelectPanel, it's not used anywhere else. (And we probably don't want it to be used anywhere else?)

@camertroncamertronAug 9, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense to me! Perhaps in a follow-up PR?

@broccolinisoupbroccolinisoupAug 12, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think we exported it recently? #4816

This comment was marked as outdated.

Sign in to view

siddharthkp
siddharthkp approved these changes Aug 9, 2024
View reviewed changes

@siddharthkpsiddharthkp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you adding more stories!

camertron
camertron approved these changes Aug 9, 2024
View reviewed changes

@camertroncamertron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you! 🎉

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 12, 2024 01:30 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 12, 2024 02:49 Inactive
@broccolinisoupbroccolinisoup added update snapshots 🤖 Command that updates VRT snapshots on the pull request and removed update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Aug 12, 2024
@primer
primerBot requested a review from a team as a code ownerAugust 12, 2024 03:04
@primer
primerBot requested a review from howdyrayAugust 12, 2024 03:04
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 12, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 12, 2024 03:09 Inactive
@broccolinisoup
broccolinisoupforce-pushed the select-panel-story-and-tests branch from 80174ab to cee7737CompareAugust 12, 2024 03:24
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 12, 2024 03:28 Inactive
@broccolinisoupbroccolinisoup added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 12, 2024
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 12, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 12, 2024 03:56 Inactive
@broccolinisoup
broccolinisoup added this pull request to the merge queueAug 12, 2024
@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Aug 12, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4829 August 12, 2024 21:43 Inactive
@broccolinisoup
broccolinisoup added this pull request to the merge queueAug 12, 2024
Merged via the queue into main with commit 529e1a3Aug 12, 2024
@broccolinisoup
broccolinisoup deleted the select-panel-story-and-tests branch August 12, 2024 22:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siddharthkpsiddharthkpsiddharthkp approved these changes
@jonrohanjonrohanAwaiting requested review from jonrohanjonrohan is a code owner automatically assigned from primer/engineer-reviewers
@howdyrayhowdyrayAwaiting requested review from howdyrayhowdyray was automatically assigned from primer/design-reviewers
+2 more reviewers
@camertroncamertroncamertron approved these changes
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@broccolinisoup@camertron@siddharthkp@langermank