Skip to content

refactor(Label): Refactor Label component to use CSS modules behind feature flag - #4893

Merged
jonrohan merged 11 commits into
mainfrom
css_modules_label
Sep 5, 2024
Merged

refactor(Label): Refactor Label component to use CSS modules behind feature flag#4893
jonrohan merged 11 commits into
mainfrom
css_modules_label

Conversation

@jonrohan

@jonrohanjonrohan commented Aug 28, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Part of https://github.com/github/primer/issues/3914

Changelog

Changed

Label refactored to use CSS modules behind the feature flag primer_react_css_modules_team

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@changeset-bot

changeset-botBot commented Aug 28, 2024•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 81e9f2b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactMinor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Aug 28, 2024
@github-actions

github-actionsBot commented Aug 28, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.54 KB (+0.14% 🔺)
packages/react/dist/browser.umd.js96.82 KB (+0.17% 🔺)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 August 28, 2024 18:47 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 August 28, 2024 18:55 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 3, 2024 16:33 Inactive
@jonrohanjonrohan changed the title Convert Label to css modulesrefactor(Label): Refactor Label component to use CSS modules behind feature flagSep 4, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 4, 2024 21:55 Inactive
@jonrohanjonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 4, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 4, 2024 22:11 Inactive
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 4, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 4, 2024 22:19 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 4, 2024 22:35 Inactive
@jonrohanjonrohan added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 4, 2024
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Sep 4, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 4, 2024 23:09 Inactive
@github-actions
github-actionsBottemporarily deployed to storybook-preview-4893 September 4, 2024 23:33 Inactive
@jonrohan
jonrohan marked this pull request as ready for review September 4, 2024 23:38
@jonrohan
jonrohan requested review from a team as code ownersSeptember 4, 2024 23:38
langermank
langermank approved these changes Sep 5, 2024
View reviewed changes

@langermanklangermank left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🔥 snapshot updates look good

@jonrohan
jonrohan added this pull request to the merge queueSep 5, 2024
Merged via the queue into main with commit 1b098edSep 5, 2024
@jonrohan
jonrohan deleted the css_modules_label branch September 5, 2024 16:38
@jonrohanjonrohan mentioned this pull request Oct 8, 2024
Merged
13 tasks
@primerprimerBot mentioned this pull request Oct 18, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
+1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

staffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonrohan@joshblack@langermank