Skip to content

Bug fix: Button loading spinner color#4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
langermank merged 4 commits into from
Sep 9, 2024
Merged

Bug fix: Button loading spinner color #4941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2b1f23
fix
langermank Sep 9, 2024
73860b1
Create calm-forks-pull.md
langermank Sep 9, 2024
e1d5fd1
test(vrt): update snapshots
langermank Sep 9, 2024
a980a26
snippy snappers
langermank Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/calm-forks-pull.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
---
"@primer/react": patch
---

Bug fix: Button loading spinner color
Binary file modified...ts/components/Button.test.ts-snapshots/Button-Loading-dark-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...pshots/components/Button.test.ts-snapshots/Button-Loading-dark-dimmed-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...components/Button.test.ts-snapshots/Button-Loading-dark-high-contrast-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...ght/snapshots/components/Button.test.ts-snapshots/Button-Loading-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...ts/components/Button.test.ts-snapshots/Button-Loading-dark-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...s/components/Button.test.ts-snapshots/Button-Loading-light-colorblind-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...ht/snapshots/components/Button.test.ts-snapshots/Button-Loading-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified...s/components/Button.test.ts-snapshots/Button-Loading-light-tritanopia-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 7 additions & 0 deletions packages/react/src/Button/__tests__/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -257,6 +257,7 @@ exports[`Button respects block prop 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -573,6 +574,7 @@ exports[`Button respects the alignContent prop 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -888,6 +890,7 @@ exports[`Button respects the large size prop 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -1204,6 +1207,7 @@ exports[`Button respects the small size prop 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -1522,6 +1526,7 @@ exports[`Button styles danger button appropriately 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -1840,6 +1845,7 @@ exports[`Button styles invisible button appropriately 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -2163,6 +2169,7 @@ exports[`Button styles primary button appropriately 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: fg.muted;
}

.c0 [data-component="loadingSpinner"] + [data-component="text"] {
Expand Down
1 change: 1 addition & 0 deletions packages/react/src/Button/styles.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -406,6 +406,7 @@ export const getButtonStyles = (theme?: Theme) => {
gridArea: 'text',
marginRight: '0px !important',
placeSelf: 'center',
color: 'fg.muted',
},
'[data-component="loadingSpinner"] + [data-component="text"]': {
visibility: 'hidden',
Expand Down
3 changes: 3 additions & 0 deletions packages/react/src/__tests__/__snapshots__/TextInput.test.tsx.snap
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1921,6 +1921,7 @@ exports[`TextInput renders trailingAction icon button 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: var(--fgColor-muted,var(--color-fg-muted,#656d76));
}

.c4 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -2552,6 +2553,7 @@ exports[`TextInput renders trailingAction text button 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: var(--fgColor-muted,var(--color-fg-muted,#656d76));
}

.c4 [data-component="loadingSpinner"] + [data-component="text"] {
Expand DownExpand Up@@ -3044,6 +3046,7 @@ exports[`TextInput renders trailingAction text button with a tooltip 1`] = `
grid-area: text;
margin-right: 0px !important;
place-self: center;
color: var(--fgColor-muted,var(--color-fg-muted,#656d76));
}

.c4 [data-component="loadingSpinner"] + [data-component="text"] {
Expand Down