Uh oh!
There was an error while loading. Please reload this page.
Update AvatarStack component to use CSS modules behind the feature flag primer_react_css_modules_team - #5012
Conversation
🦋 Changeset detectedLatest commit: c34264f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
| if (sxProp !== defaultSxProp) { | ||
| return <Box as={BaseComponent} {...rest} sx={sxProp} ref={ref} /> | ||
| } |
There was a problem hiding this comment.
@joshblack wanted to make this one change I noticed here, the wrapper function wasn't processing sx props when the flag was turned on and a prop was passed in.
joshblack
left a comment
There was a problem hiding this comment.
LGTM! Just had a couple of questions for the e2e tests
| if (sxProp !== defaultSxProp) { | ||
| return <Box as={BaseComponent} {...rest} sx={sxProp} ref={ref} /> | ||
| } |
| colorScheme: theme, | ||
| }, | ||
| }) | ||
| for (const featureFlagOn of [true, false]) { |
There was a problem hiding this comment.
One question, how do you feel about using this format for defining tests and running them:
https://github.com/primer/react/blob/main/e2e/components/Link.test.ts#L5
Also wanted to ask if you knew how to filter tests by describe block names? I wasn't sure how to do it 🤔 It's why I've been using styled-components in the name so that I could filter by that in the test name when running playwright locally
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Josh Black <joshblack@github.com>
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344069 |
Closeshttps://github.com/github/primer/issues/4024
Changelog
Changed
Update
AvatarStackcomponent to use CSS modules behind the feature flag primer_react_css_modules_teamRollout strategy
Testing & Reviewing
Merge checklist