Skip to content

Revert "Update AvatarStack component to use CSS modules behind the feature flag primer_react_css_modules_team" - #5034

Merged
joshblack merged 2 commits into
mainfrom
revert-5012-css_modules_avatar_stack
Sep 26, 2024
Merged

Revert "Update AvatarStack component to use CSS modules behind the feature flag primer_react_css_modules_team"#5034
joshblack merged 2 commits into
mainfrom
revert-5012-css_modules_avatar_stack

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Sep 26, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@changeset-bot

changeset-botBot commented Sep 26, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b2b598d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Sep 26, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5034 September 26, 2024 15:39 Inactive
@github-actions

github-actionsBot commented Sep 26, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js97.95 KB (-0.2% 🔽)
packages/react/dist/browser.umd.js98.4 KB (-0.24% 🔽)

@primer-integration

primer-integrationBot commented Sep 26, 2024•
edited by siddharthkp
Loading

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/344224

Update: It's green :)

@siddharthkpsiddharthkp mentioned this pull request Sep 26, 2024
Closed
4 tasks
@siddharthkp
siddharthkp marked this pull request as ready for review September 26, 2024 16:21
@siddharthkp
siddharthkp requested a review from a team as a code ownerSeptember 26, 2024 16:21
@siddharthkpsiddharthkp self-assigned this Sep 26, 2024
@siddharthkp

siddharthkp commented Sep 26, 2024

Copy link
Copy Markdown
MemberAuthor

@jonrohan Sorry, found issues in the PR, so have to revert :(

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5034 September 26, 2024 16:43 Inactive
@joshblack
joshblack added this pull request to the merge queueSep 26, 2024
Merged via the queue into main with commit 198fc47Sep 26, 2024
@joshblack
joshblack deleted the revert-5012-css_modules_avatar_stack branch September 26, 2024 17:02
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@broccolinisoupbroccolinisoupAwaiting requested review from broccolinisoupbroccolinisoup is a code owner automatically assigned from primer/engineer-reviewers
@jonrohanjonrohanAwaiting requested review from jonrohan
@francineluccafrancineluccaAwaiting requested review from francinelucca

Assignees

@siddharthkpsiddharthkp

Labels

staffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@joshblack