Skip to content

Run all e2e/component vrt & aat tests a second time with all css module flags on - #5070

Merged
jonrohan merged 21 commits into
mainfrom
run_vrt_aat_with_all_flags_on
Oct 7, 2024
Merged

Run all e2e/component vrt & aat tests a second time with all css module flags on#5070
jonrohan merged 21 commits into
mainfrom
run_vrt_aat_with_all_flags_on

Conversation

@jonrohan

@jonrohanjonrohan commented Oct 4, 2024

Copy link
Copy Markdown
Member

This PR enhances the CI workflow by adding a new job to run visual regression tests (VRT) and accessibility tests (AAT) with all CSS module flags enabled. This helps us find issues in Components that are using components that have been converted to CSS modules. We also will no longer need to run inline feature flag tests, as this new job will cover those scenarios.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Oct 4, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: a740fbb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Oct 4, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5070 October 4, 2024 20:21 Inactive
@github-actions

github-actionsBot commented Oct 4, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js96.7 KB (0%)
packages/react/dist/browser.umd.js97.02 KB (0%)

@jonrohanjonrohan changed the title Run vrt tests with all flags onRun all e2e/component vrt & aat tests a second time with all css module flags onOct 4, 2024
@jonrohanjonrohan added the skip changeset This change does not need a changelog label Oct 4, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5070 October 4, 2024 20:37 Inactive
@jonrohan
jonrohan marked this pull request as ready for review October 7, 2024 21:49
@jonrohan
jonrohan requested a review from a team as a code ownerOctober 7, 2024 21:49
@jonrohan
jonrohan enabled auto-merge October 7, 2024 21:49
@jonrohan
jonrohan added this pull request to the merge queueOct 7, 2024
@jonrohan
jonrohan removed this pull request from the merge queue due to a manual request Oct 7, 2024
@jonrohan
jonrohan enabled auto-merge October 7, 2024 21:56
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5070 October 7, 2024 21:58 Inactive
@jonrohan
jonrohan added this pull request to the merge queueOct 7, 2024
Merged via the queue into main with commit b91a5e5Oct 7, 2024
@jonrohan
jonrohan deleted the run_vrt_aat_with_all_flags_on branch October 7, 2024 22:20
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@joshblack