Uh oh!
There was an error while loading. Please reload this page.
Bug Fix for Text component and styled system arguments - #5079
Merged
Conversation
🦋 Changeset detectedLatest commit: e247b44 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
joshblack
left a comment
Member
There was a problem hiding this comment.
Left a comment for the helper function, was curious what you would say 🤔 Wasn't sure if this was in a fast path or not / if this component can be used a lot on a page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Josh Black <joshblack@github.com>
joshblack
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered in #5070. The
Textcomponent wasn't doing anything with styled system typography or common props. This PR adds logic to ensure that these props are correctly passed to theBoxcomponent when theTextcomponent is used with the CSS modules feature flag enabled.You can observe the bug by visiting the SegmentedControl storybook example with flag off vs flag on.
Changelog
Changed
Correctly pass styled system typography and common props to the
Boxcomponent in theTextcomponent when the CSS modules feature flag is enabled.Rollout strategy
Testing & Reviewing
Merge checklist