Uh oh!
There was an error while loading. Please reload this page.
feat(TextInput): Update TextInput to use data attributes for styling - #5242
Conversation
🦋 Changeset detectedLatest commit: 779c1f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
| expect(defaultStyles).toEqual(expect.objectContaining(expectedStyles)) | ||
| expect(blockStyles).not.toEqual(expect.objectContaining(expectedStyles)) | ||
| expect(defaultStyles).not.toEqual(expect.objectContaining(expectedStyles)) | ||
| expect(blockStyles).toEqual(expect.objectContaining(expectedStyles)) |
There was a problem hiding this comment.
Update so that variables accurately reflect what is being tests.
| validationStatus?: FormValidationStatus | ||
| /** @deprecated Use `size` prop instead */ | ||
| variant?: TextInputSizes | ||
| size?: TextInputSizes |
There was a problem hiding this comment.
Moved into the base props since that is where they are being used
| ${minWidth} | ||
| ${maxWidth} | ||
| ${sx} | ||
| } |
There was a problem hiding this comment.
Wrapped in & {...} to ensure it has greater specificity than data attributes for passed in sx prors
| ${sx}; | ||
| & { | ||
| ${sx} | ||
| } |
There was a problem hiding this comment.
Wrapped in & {...} to ensure it has greater specificity than data attributes for passed in sx prors
🔴 golden-jobs completed with status |
jonrohan
left a comment
There was a problem hiding this comment.
this change looks good to me, wanna tag in @joshblack to get his review
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350317 |
Changelog
New
Changed
getcalls with CSS variables and removed fallbacksRemoved
Rollout strategy
Testing & Reviewing
Not sure if it is a known issue but it seems that passing in
smallforsizedoes not currently do anything, whereas with the changes made, we are getting smaller inputsMerge checklist