Skip to content

Refactor Tooltip e2e tests and add sx prop story - #5248

Merged
jonrohan merged 2 commits into
mainfrom
tooltip_sx_prop_dev_stories
Nov 7, 2024
Merged

Refactor Tooltip e2e tests and add sx prop story#5248
jonrohan merged 2 commits into
mainfrom
tooltip_sx_prop_dev_stories

Conversation

@jonrohan

@jonrohanjonrohan commented Nov 7, 2024

Copy link
Copy Markdown
Member

Prelude to #5228

This adds tests for sxProp usage and refactors the e2e story tests

@jonrohan
jonrohan requested a review from a team as a code ownerNovember 7, 2024 20:19
@changeset-bot

changeset-botBot commented Nov 7, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ffbd262

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohanjonrohan added skip changeset This change does not need a changelog update snapshots 🤖 Command that updates VRT snapshots on the pull request labels Nov 7, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Nov 7, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5248 November 7, 2024 20:21 Inactive
@github-actions

github-actionsBot commented Nov 7, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js98.4 KB (0%)
packages/react/dist/browser.umd.js98.67 KB (0%)

@primer
primerBot requested a review from a team as a code ownerNovember 7, 2024 20:28
@primer
primerBot requested a review from tbenningNovember 7, 2024 20:28
@github-actionsgithub-actionsBot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Nov 7, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5248 November 7, 2024 20:31 Inactive
@jonrohan
jonrohan enabled auto-merge November 7, 2024 20:50
@jonrohan
jonrohan added this pull request to the merge queueNov 7, 2024
Merged via the queue into main with commit f743717Nov 7, 2024
@jonrohan
jonrohan deleted the tooltip_sx_prop_dev_stories branch November 7, 2024 22:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@broccolinisoupbroccolinisoupAwaiting requested review from broccolinisoupbroccolinisoup is a code owner automatically assigned from primer/engineer-reviewers
@tbenningtbenningAwaiting requested review from tbenningtbenning was automatically assigned from primer/design-reviewers
@joshblackjoshblackAwaiting requested review from joshblack
@keithamuskeithamusAwaiting requested review from keithamus
1 more reviewer
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@langermank