Skip to content

Don't deprecate Box sx prop - #5459

Merged
jonrohan merged 1 commit into
mainfrom
dont_deprecate_box_sx_prop
Dec 18, 2024
Merged

Don't deprecate Box sx prop#5459
jonrohan merged 1 commit into
mainfrom
dont_deprecate_box_sx_prop

Conversation

@jonrohan

Copy link
Copy Markdown
Member

I missed this in #5443

We don't want to deprecate Box's use of sx prop because it only is used for sx. We will likely follow up with a deprecation pr for Box

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan
jonrohan requested a review from a team as a code ownerDecember 18, 2024 22:38
@changeset-bot

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 6211e2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jonrohanjonrohan added the skip changeset This change does not need a changelog label Dec 18, 2024
@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 18, 2024
@github-actions

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js103.33 KB (0%)
packages/react/dist/browser.umd.js103.67 KB (0%)

@jonrohan
jonrohan added this pull request to the merge queueDec 18, 2024
Merged via the queue into main with commit 300c3b9Dec 18, 2024
@jonrohan
jonrohan deleted the dont_deprecate_box_sx_prop branch December 18, 2024 23:33
@jonrohanjonrohan mentioned this pull request Jan 15, 2025
13 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmskip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@langermank