Skip to content

Add eslint-plugin-clsx - #5547

Merged
hussam-i-am merged 3 commits into
mainfrom
hussam-i-am/eslint-plugin-clsx
Jan 15, 2025
Merged

Add eslint-plugin-clsx#5547
hussam-i-am merged 3 commits into
mainfrom
hussam-i-am/eslint-plugin-clsx

Conversation

@hussam-i-am

@hussam-i-amhussam-i-am commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Changelog

New

Changed

  • Adds the eslint-plugin-clsx using the recommended rules

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-amhussam-i-am self-assigned this Jan 15, 2025
@hussam-i-am
hussam-i-am requested a review from a team as a code ownerJanuary 15, 2025 18:31
@changeset-bot

changeset-botBot commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 77203e5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 15, 2025
@github-actions

github-actionsBot commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5547 January 15, 2025 18:33 Inactive
@github-actions

github-actionsBot commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.18 KB (0%)
packages/react/dist/browser.umd.js104.52 KB (0%)

hussam-i-am
hussam-i-am commented Jan 15, 2025
View reviewed changes
Comment threadpackages/react/src/Box/Box.tsx Outdated
type StyledBoxProps = {
sx?: BetterSystemStyleObject
} & SpaceProps &
type StyledBoxProps = SxProp &

@hussam-i-amhussam-i-amJan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonrohan Any reason we would not use SxProp here?

@jonrohanjonrohanJan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SxProp is deprecated, and I didn't want all Box elements to say it's deprecated since that's all the component does. #5459

@hussam-i-amhussam-i-amJan 15, 2025

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll revert it then

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5547 January 15, 2025 18:40 Inactive
@hussam-i-am
hussam-i-am added this pull request to the merge queueJan 15, 2025
@hussam-i-am
hussam-i-am removed this pull request from the merge queue due to a manual request Jan 15, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5547 January 15, 2025 21:07 Inactive
@hussam-i-am
hussam-i-am added this pull request to the merge queueJan 15, 2025
Merged via the queue into main with commit 35dec2eJan 15, 2025
@hussam-i-am
hussam-i-am deleted the hussam-i-am/eslint-plugin-clsx branch January 15, 2025 21:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohanjonrohanjonrohan approved these changes
@camertroncamertronAwaiting requested review from camertroncamertron is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@hussam-i-amhussam-i-am

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hussam-i-am@jonrohan