Skip to content

Revert "refactor(FormControl): update FormControl to use CSS Modules behind flag" - #5494

Merged
francinelucca merged 1 commit into
mainfrom
revert-5438-refactor/update-form-control-to-css-modules-3
Jan 6, 2025
Merged

Revert "refactor(FormControl): update FormControl to use CSS Modules behind flag"#5494
francinelucca merged 1 commit into
mainfrom
revert-5438-refactor/update-form-control-to-css-modules-3

Conversation

@francinelucca

@francineluccafrancinelucca commented Jan 6, 2025

Copy link
Copy Markdown
Member

Reverts #5438

Release testing revealed visual regressions, see https://github.com/github/primer/issues/3812#issuecomment-2573520523

@francinelucca
francinelucca requested a review from a team as a code ownerJanuary 6, 2025 16:59
@changeset-bot

changeset-botBot commented Jan 6, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8305542

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 6, 2025
@github-actions

github-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5494 January 6, 2025 17:02 Inactive
@github-actions

github-actionsBot commented Jan 6, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js103.4 KB (-0.29% 🔽)
packages/react/dist/browser.umd.js103.63 KB (-0.5% 🔽)

@francinelucca
francinelucca added this pull request to the merge queueJan 6, 2025
Merged via the queue into main with commit 43afd36Jan 6, 2025
@francinelucca
francinelucca deleted the revert-5438-refactor/update-form-control-to-css-modules-3 branch January 6, 2025 17:22
@hussam-i-amhussam-i-am mentioned this pull request Jan 21, 2025
Merged
1 task
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohanjonrohanjonrohan approved these changes
@joshblackjoshblackjoshblack approved these changes

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@jonrohan@joshblack