Skip to content

fix: ActionList.LinkItem duplicate classes - #5515

Closed
francinelucca wants to merge 3 commits into
mainfrom
test-actionlist
Closed

fix: ActionList.LinkItem duplicate classes#5515
francinelucca wants to merge 3 commits into
mainfrom
test-actionlist

Conversation

@francinelucca

@francineluccafrancinelucca commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Part of https://github.com/github/primer/issues/4570

Fixes an issue where className was being duplicated in LinkItem on both the wrapper li (correct) and the inner a tag (incorrect).

Changelog

Removed

  • Removes className from menuItemProps in ActionList.Item

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot

changeset-botBot commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b919972

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jan 9, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5515 January 9, 2025 15:07 Inactive
@github-actions

github-actionsBot commented Jan 9, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js103.89 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js104.21 KB (-0.02% 🔽)

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 9, 2025
@github-actions

github-actionsBot commented Jan 9, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5515 January 9, 2025 15:25 Inactive
@primer-integration

primer-integrationBot commented Jan 9, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/357139

@primer-integration

primer-integrationBot commented Jan 9, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 9, 2025
@francineluccafrancinelucca changed the title TEST: ActionList reprofix: ActionList.LinkItem duplicate classesJan 9, 2025
@francinelucca

francinelucca commented Jan 9, 2025

Copy link
Copy Markdown
MemberAuthor

closing in favor of #5517

@jonrohan
jonrohan deleted the test-actionlist branch May 9, 2025 18:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@francinelucca