Uh oh!
There was an error while loading. Please reload this page.
fix(BaseStyles): remove unknown props from fallback when feature flag is enabled - #5545
Closed
joshblack wants to merge 8 commits into
Closed
fix(BaseStyles): remove unknown props from fallback when feature flag is enabled#5545joshblack wants to merge 8 commits into
joshblack wants to merge 8 commits into
Conversation
🦋 Changeset detectedLatest commit: e40694c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
joshblack
marked this pull request as ready for review
January 15, 2025 16:29
francinelucca
approved these changes
Jan 15, 2025
joshblack
commented
Jan 15, 2025
MemberAuthor
Trying to look into what's going on with the snapshot changes 🤔 |
This reverts commit b14cd94.
joshblack
commented
Jan 27, 2025
MemberAuthor
Closing in favor of: #5606 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update how we pass along system props in BaseStyles when the CSS Modules flag is enabled. Currently, when the flag is enabled we are still passing along
color,fontFamily, andlineHeightto the underlying element. This change updates the component to use CSS Custom Properties as a bridge between what is provided as props and what is applied to the element in CSS.Changelog
New
Changed
Removed
Rollout strategy