Skip to content

fix(SelectPanel): pass anchorId to AnchoredOverlay - #5549

Merged
francinelucca merged 9 commits into
mainfrom
fix/selectpanel-a11y
Jan 23, 2025
Merged

fix(SelectPanel): pass anchorId to AnchoredOverlay#5549
francinelucca merged 9 commits into
mainfrom
fix/selectpanel-a11y

Conversation

@francinelucca

@francineluccafrancinelucca commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Closeshttps://github.com/github/accessibility-audits/issues/10036

Changelog

A FormControl's Label is not currently being associated with the SelectPanel control due to the id not being passed to the AnchoredOverlay. This PR explicitly passes the ID provided to the SelectPanel to the AnchoredOverlay's menu.

Changed

  • pass SelectPanel's id as AnchoredOverlay's anchorId
  • Modifies FormControl SelectPanel story to have voice over read label and button content

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Go to deployment, use voiceover to verify the label gets read along with the control. Compare to production where it doesn't

Merge checklist

@github-actionsgithub-actionsBot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 15, 2025
@github-actions

github-actionsBot commented Jan 15, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5549 January 15, 2025 22:12 Inactive
@changeset-bot

changeset-botBot commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 72c5d3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
NameType
@primer/reactPatch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actionsBot commented Jan 15, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.53 KB (+0.06% 🔺)
packages/react/dist/browser.umd.js104.91 KB (+0.14% 🔺)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5549 January 15, 2025 22:15 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 15, 2025
@Sunita1986Sunita1986 mentioned this pull request Jan 16, 2025
Closed
@francinelucca
francinelucca marked this pull request as ready for review January 16, 2025 17:13
@francinelucca
francinelucca requested a review from a team as a code ownerJanuary 16, 2025 17:13
@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 16, 2025
@github-actions

github-actionsBot commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5549 January 16, 2025 17:16 Inactive
@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 16, 2025
camertron
camertron approved these changes Jan 17, 2025
View reviewed changes

@camertroncamertron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@github-actions

github-actionsBot commented Jan 21, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 21, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5549 January 21, 2025 22:18 Inactive
@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 22, 2025
@github-actions

github-actionsBot commented Jan 22, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 22, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5549 January 22, 2025 01:10 Inactive
@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh labels Jan 22, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5549 January 23, 2025 00:05 Inactive
@primer-integration

primer-integrationBot commented Jan 23, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358939

@primer-integration

primer-integrationBot commented Jan 23, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 23, 2025
@francinelucca

francinelucca commented Jan 23, 2025

Copy link
Copy Markdown
MemberAuthor

Will need gh/gh updates, see Current Path to Green

@francinelucca
francinelucca added this pull request to the merge queueJan 23, 2025
Merged via the queue into main with commit 16c572eJan 23, 2025
@francinelucca
francinelucca deleted the fix/selectpanel-a11y branch January 23, 2025 15:09
@primerprimerBot mentioned this pull request Jan 22, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TylerJDevTylerJDevTylerJDev approved these changes
+2 more reviewers
@camertroncamertroncamertron approved these changes
@langermanklangermanklangermank approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@francinelucca@camertron@langermank@TylerJDev