Uh oh!
There was an error while loading. Please reload this page.
Revert "Pagination algorithm enhancements" - #5560
Merged
camertron merged 1 commit intoJan 16, 2025
Merged
Conversation
This reverts commit 9986d67.
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
joshblack
approved these changes
Jan 16, 2025
camertron
deleted the
revert-5504-hectahertz/pagination-algorithm-enhancements
branch
January 16, 2025 22:09
francinelucca added a commit
that referenced
this pull request
Jan 16, 2025
github-merge-queueBot
pushed a commit
that referenced
this pull request
Jan 30, 2025
* Revert "Revert "Pagination algorithm enhancements (#5504)" (#5560)" This reverts commit b8284ce. * Remove 'rel' attribute for disabled pagination * Revert "Remove 'rel' attribute for disabled pagination" This reverts commit 8c0c656. * Set aria-disabled=true * fix(Pagination): correct maxVisiblePages calculation * test(Pagination): correct test --------- Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com> Co-authored-by: Marie Lucca <francinelucca@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5504
We're seeing a11y-based dotcom test failures: https://github.com/github/github/actions/runs/12817716159/job/35741636983