Skip to content

Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item" - #5612

Merged
francinelucca merged 2 commits into
mainfrom
revert-5559-kendallg/progress-bar
Jan 29, 2025
Merged

Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item"#5612
francinelucca merged 2 commits into
mainfrom
revert-5559-kendallg/progress-bar

Conversation

@francinelucca

@francineluccafrancinelucca commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Reverts #5559 due to failing CI checks in gh/gh

@changeset-bot

changeset-botBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 349fa87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Jan 28, 2025
@github-actions

github-actionsBot commented Jan 28, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 28, 2025
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5612 January 28, 2025 04:52 Inactive
@github-actions

github-actionsBot commented Jan 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js104.43 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js104.82 KB (-0.1% 🔽)

@primer-integration

primer-integrationBot commented Jan 28, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/359596

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 28, 2025
@kendallgassner
kendallgassner marked this pull request as ready for review January 28, 2025 18:48
@kendallgassner
kendallgassner requested a review from a team as a code ownerJanuary 28, 2025 18:48
kendallgassner
kendallgassner approved these changes Jan 28, 2025
View reviewed changes

@kendallgassnerkendallgassner left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree lets revert until I can fix the intergration failures! Apologies for the issues

@kendallgassnerkendallgassner mentioned this pull request Jan 28, 2025
Merged
14 tasks
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5612 January 28, 2025 20:12 Inactive
@francineluccafrancinelucca changed the title TEST Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item"Revert "[Accessibility][Storybook] Add aria-labels to the multiple item progress bar + enforce aria-label in progressbar.item"Jan 29, 2025
@primer-integration

primer-integrationBot commented Jan 29, 2025

Copy link
Copy Markdown

🟢 golden-jobs completed with status success.

@github-actionsgithub-actionsBot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Jan 29, 2025
@francinelucca
francinelucca added this pull request to the merge queueJan 29, 2025
Merged via the queue into main with commit a1122e4Jan 29, 2025
@francinelucca
francinelucca deleted the revert-5559-kendallg/progress-bar branch January 29, 2025 04:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@kendallgassnerkendallgassnerkendallgassner approved these changes

Assignees

No one assigned

Labels

integration-tests: passingChanges in this PR do NOT cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@francinelucca@joshblack@kendallgassner