Uh oh!
There was an error while loading. Please reload this page.
Make Dialog footer scrollable on very short viewports - #5629
Merged
Conversation
🦋 Changeset detectedLatest commit: 84c7ac5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
hectahertztemporarily deployed
to
github-pages
January 30, 2025 20:02 — with 
GitHub Actions
Inactive
joshblack
approved these changes
Jan 31, 2025
hectahertztemporarily deployed
to
github-pages
February 7, 2025 12:50 — with GitHub Actions
Inactive
hectahertztemporarily deployed
to
github-pages
February 7, 2025 18:53 — with GitHub Actions
Inactive
Uh oh!
There was an error while loading. Please reload this page.
13 tasks
TylerJDev
left a comment
Member
There was a problem hiding this comment.
Left a few more comments, curious on what you think! Looks almost good to go 🚀
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
lesliecdubs
commented
Mar 14, 2025
Member
Ping @hectahertz, would be awesome to get this one over the line before you fully switch focus to the next epic 🙇🏻♀️ |
hectahertzforce-pushed
the
hectahertz/dialog-footer-wrapping
branch
from
March 20, 2025 18:10
c0bee5e to
e62c9a9Comparehectahertzforce-pushed
the
hectahertz/dialog-footer-wrapping
branch
from
March 20, 2025 18:12
e62c9a9 to
9e64451Comparehectahertz
enabled auto-merge
March 28, 2025 17:59
francinelucca added a commit
that referenced
this pull request
Mar 29, 2025
This reverts commit b7346b2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the work to improve reflow of the component. This helps to make all the footer buttons accessible on small screens and gives some extra breathing room to the body.
Changelog
Changed
Dialog footer becomes scrollable on very short viewports.
Before
Screen.Recording.2025-01-30.at.20.46.28.mov
After
Screen.Recording.2025-01-30.at.20.46.08.mov
Rollout strategy
Testing & Reviewing
The CSS changes seem a bit esoteric, but are due to
overflow: scrollnot being compatible withjustify-content: flex-end.flex-direction: row-reverse; flex-wrap: wrap-reverse;plus reversing the items is visually equivalent but compatible. The focus order keeps being the same.Merge checklist