Skip to content

TEST Revert "Make Dialog footer scrollable on very short viewports" - #5840

Closed
francinelucca wants to merge 1 commit into
mainfrom
revert-5629-hectahertz/dialog-footer-wrapping
Closed

TEST Revert "Make Dialog footer scrollable on very short viewports"#5840
francinelucca wants to merge 1 commit into
mainfrom
revert-5629-hectahertz/dialog-footer-wrapping

Conversation

@francinelucca

@francineluccafrancinelucca commented Mar 29, 2025

Copy link
Copy Markdown
Member

Reverts #5629

@changeset-bot

changeset-botBot commented Mar 29, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0a8345a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Mar 29, 2025
@github-actions

github-actionsBot commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 29, 2025
@github-actions

github-actionsBot commented Mar 29, 2025

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js105.37 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js105.78 KB (+0.09% 🔺)

@primer-integration

primer-integrationBot commented Mar 29, 2025

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370190

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5840 March 29, 2025 04:31 Inactive
@primer-integration

primer-integrationBot commented Mar 29, 2025

Copy link
Copy Markdown

🔴 golden-jobs completed with status failure.

@github-actionsgithub-actionsBot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 29, 2025
@primer
primerBot deleted the revert-5629-hectahertz/dialog-footer-wrapping branch June 30, 2026 18:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

integration-tests: failingChanges in this PR cause breaking changes in gh/ghstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@francinelucca